[dualtor] Add demo test template for active-active cable type
#5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
|
This pull request introduces 5 alerts when merging 51e337e into 155af03 - view on LGTM.com new alerts:
|
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
|
This pull request introduces 5 alerts when merging 256c9bd into 155af03 - view on LGTM.com new alerts:
|
zjswhhh
pushed a commit
to zjswhhh/sonic-mgmt
that referenced
this pull request
Apr 20, 2022
…c-net#5424) Approach What is the motivation for this PR? Modify testcase test_normal_op.py::test_normal_op_upstream to support parameterization based on cable type(active-active or active-standby). This PR acts as a roadmap on how to support cable type parameterization further for all dualtor_io testcases. Signed-off-by: Longxiang Lyu lolv@microsoft.com How did you do it? 1. Add parameterization fixture cable_type. 2. Let existing fixtures for dualtor active-standby selects ports in active-standby cable type to test. 3. List out the basic APIs for active-active tests control/data plane fixtures. How did you verify/test it? Run the test test_normal_op.py::test_normal_op_upstream:
5 tasks
zjswhhh
added a commit
that referenced
this pull request
May 18, 2022
… type (#5545) ### Description of PR Summary: Fixes # (issue) Submitting this PR to re-add test template for `active-active` cable type. The change (#5424) was reverted earlier due to regression. sign-off: Jing Zhang zhangjing@microsoft.com ### Type of change - [x] Test case(new/improvement) #### What is the motivation for this PR? Re-add the roadmap for supporting `active-active` dualtor_io testcases. #### How did you do it? 1. Pick the commit from the original PR. 2. Import `cable_type` fixture where the modified fixtures are requested. 3. Update `data_plane_utils.py` to re-use `DualtorIO` object. #### How did you verify/test it? Tested `test_normal_op` and `test_link_failure`, all passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Modify testcase
test_normal_op.py::test_normal_op_upstreamto support parameterization based on cable type(active-activeoractive-standby).This PR acts as a roadmap on how to support cable type parameterization further for all dualtor_io testcases.
Signed-off-by: Longxiang Lyu lolv@microsoft.com
How did you do it?
cable_type.active-standbyselects ports inactive-standbycable type to test.active-activetests control/data plane fixtures.How did you verify/test it?
Run the test
test_normal_op.py::test_normal_op_upstream:Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation