Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip span mirror test on unsupported release #5400

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Skip span mirror test on unsupported release #5400

merged 1 commit into from
Apr 5, 2022

Conversation

bingwang-ms
Copy link
Collaborator

Signed-off-by: bingwang bingwang@microsoft.com

Description of PR

Summary:
This PR is to skip span mirroring test on release prior to 202012.
The support of span mirroring was introduced by PR sonic-net/sonic-utilities#936 . The change is backported into 202012 branch but not into 201811 and 201911. Hence we are not able to run this test on 201811 and 201911.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012

Approach

What is the motivation for this PR?

This PR is to skip span mirroring test on release prior to 202012.

How did you do it?

Add a session level, autoused fixture to check release, and skip if not supported.

How did you verify/test it?

Verified on 201911 branch, and confirm the test is skipped.

collected 4 items                                                                                                                                                                                     

span/test_port_mirroring.py::test_mirroring_rx SKIPPED                                                                                                                                          [ 25%]
span/test_port_mirroring.py::test_mirroring_tx SKIPPED                                                                                                                                          [ 50%]
span/test_port_mirroring.py::test_mirroring_both SKIPPED                                                                                                                                        [ 75%]
span/test_port_mirroring.py::test_mirroring_multiple_source SKIPPED                                                                                                                             [100%]

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

No.

Documentation

@bingwang-ms
Skip span mirror test on unsupported release
5d887bf 
Signed-off-by: bingwang <bingwang@microsoft.com>
@bingwang-ms bingwang-ms requested a review from a team as a code owner March 25, 2022 07:14
@bingwang-ms
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

lolyu
lolyu approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingwang-ms
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms bingwang-ms merged commit caa0651 into sonic-net:master Apr 5, 2022
wangxin pushed a commit that referenced this pull request Apr 7, 2022
@bingwang-ms @wangxin
Skip span mirror test on unsupported release (#5400)
e2d35a3 
Signed-off-by: bingwang <bingwang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolyu lolyu lolyu approved these changes

Assignees
No one assigned
Labels
Included in 202012 branch Request for 202012 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bingwang-ms @lolyu @wangxin