[snmp] test_snmp_interfaces_mibs fix KEY_ERROR issue on L2 config #4058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrii-Yosafat Lozovyi <andrii-yosafatx.lozovyi@intel.com>
qiluo-msft
approved these changes
Aug 17, 2021
|
thanks for contributing, the correct syntax for Fix is this |
|
@AndriiLozovyi - could you please backport this fix to 202012? |
|
@roysr-nv, |
@AndriiLozovyi - you're right, for some reason I was sure that the fix is in sonic-build(since there original bug is there) |
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
…nic-net#4058) Changed the way value was extracted from dict by using get('description', '') function, in order to fix test case fail with L2 config deployed on DUT. Signed-off-by: Andrii-Yosafat Lozovyi <andrii-yosafatx.lozovyi@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrii-Yosafat Lozovyi andrii-yosafatx.lozovyi@intel.com
Description of PR
Summary: Changed the way value was extracted from dict by using get('description', '') function, in order to fix test case fail with L2 config deployed on DUT.
Fix sonic-net/sonic-buildimage#8310
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix test fail with L2 configuration deployed on DUT.
How did you do it?
Changed the way value was extracted from dict.
How did you verify/test it?
Run test case with L2 config deployed on DUT:
snmp/test_snmp_interfaces.py::test_snmp_interfaces_mibs PASSED
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation