Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial spytest upstream #1533

Merged
merged 1 commit into from
Apr 3, 2020
Merged

initial spytest upstream #1533

merged 1 commit into from
Apr 3, 2020

Conversation

ramakristipati
Copy link
Contributor

@ramakristipati ramakristipati commented Apr 3, 2020

Signed-off-by: Rama Sasthri, Kristipati rama.kristipati@broadcom.com

Description of PR

This is initial check-in of spytest framework and first set of test scripts

Summary:
New Feature

Type of chang

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?

used pytest as base and add needed feature on top of it
developed test scripts to excercise sonic features like port, vlan, portchannel, ARP etc

How did you verify/test it?

Executed test scripts against sonic daily build

  PassRate Executed PassCount TimeTaken SysLogs EnvFailRate SkippedRate CDT
Regression 91.43% 105 96 1:55:49 0 0.00% 0.00% 7:43:16
==== TOTAL ==== 91.43% 105 96 1:55:49 0 0.00% 0.00% 7:43:16
  PassRate SysLogs CDT FCLI TSSH DCNT Functions PrologTime EpilogTime FuncTime ExecTime PASS FAIL ENVFAIL SCRIPTERROR DEPFAIL CONFIGFAIL SKIPPED TIMEOUT TOPOFAIL TGENFAIL DUTFAIL UNSUPPORTED
system/test_ssh.py 100.00% 0 0:10:56 0 0 4 1 0:02:27 0:00:08 0:00:09 0:02:44 1 0 0 0 0 0 0 0 0 0 0 0
system/test_box_services.py 100.00% 0 0:13:08 0 0 4 1 0:02:07 0:00:00 0:01:10 0:03:17 1 0 0 0 0 0 0 0 0 0 0 0
system/test_ntp.py 0.00% 0 0:15:44 0 0 4 1 0:02:35 0:00:01 0:01:20 0:03:56 0 1 0 0 0 0 0 0 0 0 0 0
routing/BGP/test_bgp_4node.py 100.00% 0 0:17:12 0 0 4 3 0:02:36 0:00:22 0:01:20 0:04:18 3 0 0 0 0 0 0 0 0 0 0 0
security/test_tacacs.py 100.00% 0 0:17:24 0 0 4 3 0:02:23 0:00:20 0:01:38 0:04:21 3 0 0 0 0 0 0 0 0 0 0 0
routing/test_ip.py 100.00% 0 0:18:56 0 0 4 2 0:02:51 0:00:54 0:00:59 0:04:44 2 0 0 0 0 0 0 0 0 0 0 0
routing/test_arp.py 0.00% 0 0:22:08 0 0 4 1 0:02:37 0:00:08 0:02:47 0:05:32 0 1 0 0 0 0 0 0 0 0 0 0
system/test_device_mgmt.py 100.00% 0 0:22:08 0 0 4 1 0:05:03 0:00:01 0:00:28 0:05:32 1 0 0 0 0 0 0 0 0 0 0 0
system/test_lldp.py 100.00% 0 0:25:04 0 0 4 9 0:04:28 0:00:22 0:01:26 0:06:16 9 0 0 0 0 0 0 0 0 0 0 0
switching/test_portchannel.py 50.00% 0 0:35:16 0 0 4 2 0:04:16 0:00:18 0:04:15 0:08:49 1 1 0 0 0 0 0 0 0 0 0 0
sanity/test_sanity_l2.py 100.00% 0 0:42:32 0 0 4 4 0:02:11 0:00:01 0:08:26 0:10:38 4 0 0 0 0 0 0 0 0 0 0 0
routing/BGP/test_bgp.py 100.00% 0 0:56:56 0 0 4 19 0:06:48 0:01:10 0:06:16 0:14:14 19 0 0 0 0 0 0 0 0 0 0 0
qos/test_qos_save_reboot.py 100.00% 0 1:21:12 0 0 4 1 0:16:24 0:00:03 0:03:51 0:20:18 1 0 0 0 0 0 0 0 0 0 0 0
system/test_snmp.py 88.24% 0 1:25:36 0 0 4 17 0:15:57 0:00:29 0:04:58 0:21:24 15 1 0 0 0 0 0 0 0 0 1 0
==== TOTAL ==== 92.31% 0 7:44:12 0 0 56 65 1:12:43 0:04:17 0:39:03 1:56:03 60 4 0 0 0 0 0 0 0 0 1 0

Any platform specific information?

None

Supported testbed topology if it's a new test case?

PTF

Documentation

TODO

Signed-off-by: Rama Sasthri, Kristipati <rama.kristipati@broadcom.com>
@msftclas
Copy link

msftclas commented Apr 3, 2020

CLA assistant check
All CLA requirements met.

@yxieca yxieca self-requested a review April 3, 2020 16:02
@lgtm-com
Copy link

lgtm-com bot commented Apr 3, 2020

This pull request introduces 402 alerts when merging 5579a06 into edc1d5c - view on LGTM.com

new alerts:

  • 174 for Except block handles 'BaseException'
  • 118 for Unused local variable
  • 30 for Testing equality to None
  • 26 for Unreachable code
  • 18 for Variable defined multiple times
  • 5 for Non-iterable used in for loop
  • 4 for Use of the return value of a procedure
  • 4 for Modification of parameter with default
  • 4 for Result of integer division may be truncated
  • 3 for Nested loops with same variable
  • 3 for Insecure temporary file
  • 2 for Membership test with a non-container
  • 2 for Unused argument in a formatting call
  • 1 for Too few arguments in formatting call
  • 1 for Module is imported more than once
  • 1 for Non-callable called
  • 1 for Unused import
  • 1 for Suspicious unused loop iteration variable
  • 1 for Module is imported with 'import' and 'import from'
  • 1 for Use of 'global' at module level
  • 1 for Wrong number of arguments in a call
  • 1 for __init__ method calls overridden method

@yxieca
Copy link
Collaborator

yxieca commented Apr 3, 2020

@ramakristipati Please create subsequent PRs to address the LGTM alerts.

@yxieca yxieca merged commit f3b4e51 into sonic-net:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants