Adding a new testcase to check if mac learning happens correctly #13912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CharudattaSChitale Suggest not back port to 202305? Can we? |
|
The original MAC Learning issue was found in 202305 (https://migsonic.atlassian.net/browse/MIGSMSFT-424) |
kevinskwang
approved these changes
Sep 19, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kevinskwang
approved these changes
Sep 27, 2024
kevinskwang
added
Approved for 202405 branch
and removed
Request for 202311 branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Sep 27, 2024
|
Cherry-pick PR to 202405: #14779 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 27, 2024
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation for this PR?
When the DUT performs MAC Learning, a situation may arise such that even if the interface is shutdown, 'show mac' will show previously learnt MAC addresses on the 'Down' interfaces. These stale entries will persist even after doing 'sonic-clear fdb all'
This Testcase covers this scenario and makes sure that stale entries are removed
How did you do it?
Followed below steps to recreate the scenario
-shut down all ports
-config save
-config reload
-bring up 1 port. populate fdb
-bring up 3 more ports. populate fdb.
-shut down 3 ports added in last step
-verify that MAC entries connected to shutdown ports are gone from MAC table
-sonic-clear fdb all
-populate fdb for the UP port
-verify that the MAC entries connected to shutdown ports don't show up in the MAC table again
Type of change
-Test case(new)
Back port request
-202305
-202311
-202405
How did you verify/test it?
Tested on an Image which does not have a fix for this issue. Made sure that TC fails.
Tested on an Image with the fix. Made sure that TC passes.