-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Arista] Add port definitions for 7060X6 HwSkus in port_utils #13102
Conversation
The pre-commit check detected issues in the files touched by this pull request. Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
f1b5702
to
399f536
Compare
I have tried the port config file and some I am hitting this issue before due to Ethernet2 key is missing in the hwsku_dict: and the hwsku.json looks like below: @ccroy-arista , do you mind to help see if anything is missing and related to this change? Thanks a lot! |
399f536
to
1e00f14
Compare
@r12f this issue is unrelated to this change so this one should be ready to go. You are running into the subport issue. |
Hi Samuel, is the build image change back ported to 202311? |
after deploying this change, deploying minigraph is not failing anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. consider approved after fixing the CI.
/azpw run Azure.sonic-mgmt |
/AzurePipelines run Azure.sonic-mgmt |
Azure Pipelines successfully started running 1 pipeline(s). |
…net#13102) * [Arista] Add port definitions for 7060X6 * [Arista] Register HwSku to the broadcom ASIC lists
@yxieca @bingwang-ms Please help to approve the request labels. |
@yxieca @bingwang-ms Please help to approve the request labels. |
…net#13102) * [Arista] Add port definitions for 7060X6 * [Arista] Register HwSku to the broadcom ASIC lists
Cherry-pick PR to 202405: #14345 |
…net#13102) * [Arista] Add port definitions for 7060X6 * [Arista] Register HwSku to the broadcom ASIC lists
Cherry-pick PR to 202311: #14346 |
* [Arista] Add port definitions for 7060X6 * [Arista] Register HwSku to the broadcom ASIC lists
* [Arista] Add port definitions for 7060X6 * [Arista] Register HwSku to the broadcom ASIC lists
Description of PR
Summary: Add port definition for Arista 7060X6 HwSkus in port_utils
Type of change
Back port request
Approach
What is the motivation for this PR?
Allow add-topo to properly generate a minigraph on these new 7060X6 HwSku
Also register these HwSku into the
broadcom_<asic>_hwskus
to allow some tests to pass.How did you do it?
Added the definitions of the 7060X6 HwSkus in the
port_utils.py
andvariables
filesHow did you verify/test it?
Ran t0 and t1 topologies on these HwSkus
Any platform specific information?
Specific to Arista 7060X6