Support share image for gnmi and telemetry #10348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganglyu
changed the title
qiluo-msft
reviewed
Oct 27, 2023
| test_service = "telemetry" | ||
| logging.info("Bringing down telemetry service") | ||
| service_status = duthost.critical_process_status("telemetry") | ||
| containers_states, succeeded = duthost.get_feature_status() |
There was a problem hiding this comment.
Feature config is not correct, for example, telemetry is enabled, but there's no telemetry service.
I will use docker image to check feature status, if there's telemetry docker image, we should telemetry service.
qiluo-msft
reviewed
Oct 27, 2023
tests/gnmi/helper.py
Outdated
| class GNMIEnvironment(object): | ||
| def __init__(self, duthost): | ||
| self.duthost = duthost | ||
| self.use_gnmi_container = duthost.shell("docker ps | grep -w gnmi", module_ignore_errors=True)['rc'] == 0 |
There was a problem hiding this comment.
Will user docker image instead.
zbud-msft
reviewed
Oct 30, 2023
zbud-msft
approved these changes
Oct 31, 2023
zbud-msft
reviewed
Oct 31, 2023
zbud-msft
approved these changes
Oct 31, 2023
ganglyu
added a commit
to ganglyu/sonic-mgmt
that referenced
this pull request
Nov 9, 2023
What is the motivation for this PR? We will share docker image to support gnmi and telemetry. So we need to update minigraph, gnmi and telemetry test to support this change. How did you do it? For telemetry test, check telemetry container at first, if there's no telemetry container, use gnmi container. For gnmi test, check gnmi container at first, if there's no gnmi container, use telemetry container. For minigraph test, check feature status to choose service. How did you verify/test it? Run end to end test.
7 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Nov 10, 2023
* Support share image for gnmi and telemetry (#10348) What is the motivation for this PR? We will share docker image to support gnmi and telemetry. So we need to update minigraph, gnmi and telemetry test to support this change. How did you do it? For telemetry test, check telemetry container at first, if there's no telemetry container, use gnmi container. For gnmi test, check gnmi container at first, if there's no gnmi container, use telemetry container. For minigraph test, check feature status to choose service. How did you verify/test it? Run end to end test. * Ignore telemetry container in loganalyzer check (#10637) What is the motivation for this PR? We will remove telemetry container in public repo, and FEATURE config for telemetry is still enabled. Therefore, we need ignore syslog error. How did you do it? Update loganalyzer_common_ignore.txt. How did you verify/test it? Run end to end test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Support container update for telemetry and gnmi.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
We will share docker image to support gnmi and telemetry.
So we need to update minigraph, gnmi and telemetry test to support this change.
How did you do it?
For telemetry test, check telemetry container at first, if there's no telemetry container, use gnmi container.
For gnmi test, check gnmi container at first, if there's no gnmi container, use telemetry container.
For minigraph test, check feature status to choose service.
How did you verify/test it?
Run minigraph, gnmi and telemetry end to end test.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation