Align with new HLD schema #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
requested review from
prsunny,
Pterosaur,
kperumalbfn and
prabhataravind
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
prsunny
approved these changes
Mar 12, 2024
Pterosaur
reviewed
Mar 12, 2024
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
changed the title
…pi into route-group
Pterosaur
approved these changes
Apr 11, 2024
prsunny
reviewed
Apr 29, 2024
|
@pranjal-git to review |
r12f
reviewed
May 18, 2024
proto/route_rule.proto
Outdated
| // Optional | ||
| // optional region_id which the vni/prefix belongs to as a string for any vendor optimizations | ||
| optional string region = 7; | ||
| optional string region = 8; |
There was a problem hiding this comment.
is this field needed? looks like we don't have this field in SAI.
There was a problem hiding this comment.
This field is present in the HLD, should we remove it from there if it's unneeded?
proto/vnet_mapping.proto
Outdated
| // Optional | ||
| optional bool use_pl_sip_eni = 7; | ||
| optional bool use_pl_sip_eni = 6; |
There was a problem hiding this comment.
do we need to remove this field?
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
force-pushed
the
route-group
branch
from
5cdd237
to
747425a
Compare
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
- Marking original action_type as deprecated to prevent breaking existing code Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
force-pushed
the
route-group
branch
2 times, most recently
from
0a1151b
to
6668ccb
Compare
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
force-pushed
the
route-group
branch
from
6668ccb
to
95fa234
Compare
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
yxieca
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Aug 13, 2024
What I did For DASH_ROUTE_TABLE entries, change action_type references to routing_type references. Why I did it sonic-net/sonic-dash-api#20 deprecates action_type in DASH_ROUTE_TABLE in favor of routing_type to more accurately describe the field. Any downstream repositories which build SWSS will see a deprecation warning for action_type and builds with -Werror set will not compile. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align DASH API with newest HLD changes: sonic-net/DASH#520 and sonic-net/SONiC#1658