Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[celestica/silverstone]: Update platform driver and platform APIs #9879

Closed
wants to merge 13 commits into from

Conversation

mudsut4ke
Copy link
Contributor

@mudsut4ke mudsut4ke commented Jan 28, 2022

Why I did it

  • Platform driver and APIs must support F2B and B2F SKUs
  • Platform APIs must passed all test cases in the SONIC Platform Testing Framework.

How I did it

  • Update platform driver to support latest firmware
  • Update Platform APIs to follow latest spec and fixes failed test cases
  • Update Silverstone Switch configuration

How to verify it

  • Run platform test on testbed

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

@mudsut4ke mudsut4ke marked this pull request as ready for review January 28, 2022 07:33
@lgtm-com
Copy link

lgtm-com bot commented Jan 28, 2022

This pull request introduces 5 alerts and fixes 30 when merging b041ee0 into bcf5388 - view on LGTM.com

new alerts:

  • 2 for Unused import
  • 2 for Variable defined multiple times
  • 1 for Unnecessary pass

fixed alerts:

  • 11 for Unused import
  • 8 for Unused local variable
  • 6 for Except block handles 'BaseException'
  • 5 for Wrong number of arguments in a class instantiation

@sujinmkang
Copy link
Collaborator

@mudsut4ke Can you please share the output of show platform & show interface commands and sonic-mgmt platform api test result?

@sujinmkang
Copy link
Collaborator

@mudsut4ke Can you also check the build failure?

@mudsut4ke
Copy link
Contributor Author

@mudsut4ke Can you also check the build failure?

@sujinmkang , The error is caused by the driver file not supporting kernel 5.10 in the master branch.
Since in the code on local repo is based on the 202012 branch that using kernel version 4.19

Can I make a new PR to 202012 branch directly ?

@sujinmkang
Copy link
Collaborator

@mudsut4ke Yes, please open a new PR against your expected branch. Do you also plan to have a new PR to support for master branch, kernel 5.0?

@mudsut4ke
Copy link
Contributor Author

@mudsut4ke Yes, please open a new PR against your expected branch. Do you also plan to have a new PR to support for master branch, kernel 5.0?

@sujinmkang , Yes, I will close this PR first
And here is a new PR #9911 for 202012 branch

@mudsut4ke mudsut4ke closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants