Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PR, no need to review, thx #9652

Draft
wants to merge 196 commits into
base: master
Choose a base branch
from

Conversation

seanwu-ec
Copy link
Contributor

This branch include these PRs:
Sean:
#7615
#8115
#8220
#8346

Jostar:
#6691
#7520
#7627
#7757
#7966
#8164
#8555
#8580
#8638
#8760
#9112
#9170

Brandon:
#3882
#7577
#8139

Roy:
#3866

Merge PDDF as well:
#8014
#7828
#8040

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

jostar-yang and others added 30 commits June 12, 2019 17:42
Signed-off-by: roy_lee <roy_lee@accton.com>
Insmod ym driver also, for psu is exchangable.
Signed-off-by: roy_lee <roy_lee@accton.com>
Signed-off-by: brandon_chuang <brandon_chuang@edge-core.com>
Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
* Remove unused variables, make it warning free.

Signed-off-by: Sean Wu <sean_wu@edge-core.com>
* Remove unused variable, make it warning free.

Signed-off-by: Sean Wu <sean_wu@edge-core.com>
@lgtm-com
Copy link

lgtm-com bot commented Dec 30, 2021

This pull request introduces 2 alerts and fixes 16 when merging 4fa2e78 into b0f0d4e - view on LGTM.com

new alerts:

  • 2 for Wrong name for an argument in a call

fixed alerts:

  • 15 for Unused import
  • 1 for Unused local variable

Signed-off-by: Sean Wu <sean_wu@edge-core.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 6, 2022

This pull request introduces 2 alerts and fixes 16 when merging d21da0f into abbd173 - view on LGTM.com

new alerts:

  • 2 for Wrong name for an argument in a call

fixed alerts:

  • 15 for Unused import
  • 1 for Unused local variable

* This solve flooding DMAR err msg: "handling fault status reg 2"

Signed-off-by: Sean Wu <sean_wu@edge-core.com>
* Use kernel 5.10.46 upstream at24 driver directly. The ADDR16 issue on
old driver has gone.

Signed-off-by: Sean Wu <sean_wu@edge-core.com>
* otherwise, sometimes I2C-0/I2C-1 will be assigned to the undesired one.

Signed-off-by: Sean Wu <sean_wu@edge-core.com>
Signed-off-by: Sean Wu <sean_wu@edge-core.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 7, 2022

This pull request introduces 2 alerts and fixes 16 when merging b49c3d7 into 6c50732 - view on LGTM.com

new alerts:

  • 2 for Wrong name for an argument in a call

fixed alerts:

  • 15 for Unused import
  • 1 for Unused local variable

@seanwu-ec
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lgtm-com
Copy link

lgtm-com bot commented Jan 11, 2022

This pull request introduces 2 alerts and fixes 16 when merging 0848bc3 into 94b778c - view on LGTM.com

new alerts:

  • 2 for Wrong name for an argument in a call

fixed alerts:

  • 15 for Unused import
  • 1 for Unused local variable

FuzailBrcm and others added 14 commits January 11, 2022 09:51
…ilation (sonic-net#9582)

- Why I did it
There were compilation errors and warnings like,

/usr/src/linux-headers-5.10.0-8-2-common/scripts/Makefile.build:69: You cannot use subdir-y/m to visit a module Makefile. Use obj-y/m instead.

fatal error: linux/platform_data/pca954x.h: No such file or directory

hwmon_device_register() is deprecated. Please convert the driver to use hwmon_device_register_with_info().

If PDDF kernel module compilation fails, the PDDF debian package was not detecting the break.

- How I did it
Modified the code with new kernel 5.10 APIs.
Modified the Makefiles to use 'obj-m' instead of 'subdir-y'

- How to verify it
PDDF is supported on Accton platform. Load the build on AS7326 setup and check the 'dmesg'
sonic-net#9585)

- Why I did it
PDDF utils were python2 compliant and they needed to be migrated to Python3 (as per Bullseye)
PDDF common platform APIs file name changed as the name was already in use
Indentation issues
Dead/redundant code needed to be removed

- How I did it
Made files Python3 compliant
Indentation corrected
Redundant code removed

- How to verify it
AS7326 Accton platform uses PDDF. PDDF utils were run on this platform to verify.
Signed-off-by: Sean Wu <sean_wu@edge-core.com>
Signed-off-by: Sean Wu <sean_wu@edge-core.com>
Signed-off-by: Sean Wu <sean_wu@edge-core.com>
Signed-off-by: Sean Wu <sean_wu@edge-core.com>
Signed-off-by: Sean Wu <sean_wu@edge-core.com>
Signed-off-by: Sean Wu <sean_wu@edge-core.com>
Signed-off-by: Sean Wu <sean_wu@edge-core.com>
Signed-off-by: Sean Wu <sean_wu@edge-core.com>
Signed-off-by: Sean Wu <sean_wu@edge-core.com>
Signed-off-by: Sean Wu <sean_wu@edge-core.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 18, 2022

This pull request introduces 2 alerts and fixes 16 when merging 7ee287d into c80dabd - view on LGTM.com

new alerts:

  • 2 for Wrong name for an argument in a call

fixed alerts:

  • 15 for Unused import
  • 1 for Unused local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants