[AS7326-56X] Support mulit PSU SN in PDDF #7966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
FuzailBrcm
reviewed
Jun 24, 2021
platform/broadcom/sonic-platform-modules-accton/as7326-56x/modules/pddf_custom_psu.c
Outdated
Show resolved
Hide resolved
platform/broadcom/sonic-platform-modules-accton/as7326-56x/modules/pddf_custom_psu.c
Outdated
Show resolved
Hide resolved
FuzailBrcm
previously approved these changes
Jun 24, 2021
FuzailBrcm
reviewed
Jul 28, 2021
platform/broadcom/sonic-platform-modules-accton/as7326-56x/modules/pddf_custom_psu.c
Show resolved
Hide resolved
5 tasks
FuzailBrcm
reviewed
Dec 29, 2021
platform/broadcom/sonic-platform-modules-accton/as7326-56x/modules/Makefile
Show resolved
Hide resolved
prgeor
previously approved these changes
Feb 7, 2022
FuzailBrcm
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Changes look good to me.
However, this change require the following PR to be merged
[AS7326-5X] Fix code bug for led drv (#8555)
|
/azpw run |
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 7966 in repo Azure/sonic-buildimage |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 7966 in repo Azure/sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 7966 in repo Azure/sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 7966 in repo Azure/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Close this PR because PR10053 remove pddf files. It cause file conflict, but no write access here. This PR become invalid. So close and send as7326 needed file in PR #10340. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jostar Yang jostar_yang@accton.com.tw
Why I did it
AS7326 support 3Y and ACBEL PSU. So it need customer drv to handle access psu serial_number and model_name on different PSU.
How I did it
Implement pddf_custom_psu.c drv code.
How to verify it
#pddf_psuutil mfrinfo
PSU Status Manufacturer ID Model Serial Fan Airflow Direction
PSU1 OK ACBEL FSF019-610 FSF0191813105520 EXHAUST
PSU2 OK ACBEL FSF019-610 FSF0191813105521 EXHAUST
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)