added mclag sonic yang

[gitsabari]

Why I did it

How I did it

Added mclag sonic yang file for the MCLAG enhancements as per HLD: sonic-net/SONiC#596

How to verify it

try rest APIs

Description for the changelog

Added mclag sonic yang

A picture of a cute animal (not mandatory but encouraged)

[rlhui]

Tests are missing? Thanks.

[gitsabari]

/azpw run azure.sonic-buildimage

[mssonicbld]

/AzurePipelines run azure.sonic-buildimage

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[gitsabari]

@zhangyanzhao
unrelated build issue. can you please get some help for this build issue. other than this. this PR can be merged once build done
gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
make: *** [slave.mk:796: target/docker-gbsyncd-vs.gz] Error 2

[zhangyanzhao]

Rajesh Vel in BRCM will come back later.

[gitsabari]

@zhangyanzhao
there seems to be generic issue. there are some test cases failing and it is not related to this change
please get some help to resolve this and also this PR can be merged it is already approved by yang.

======= 4 failed, 1631 passed, 3 skipped, 8 warnings in 1270.60 seconds ========

def test_extend__path_with_refs_to_children__extended_moves(self):
    self.verify(OperationType.REMOVE,
                ["PORT"],
                tc_ops=[{'op':'remove', 'path':'/PORT/Ethernet0'}],
                ex_ops=[{'op': 'remove', 'path': '/VLAN_MEMBER/Vlan1000|Ethernet0'},
                        {'op': 'remove', 'path': '/ACL_TABLE/NO-NSW-PACL-V4/ports/0'},
                        {'op': 'remove', 'path': '/VLAN_MEMBER/Vlan1000|Ethernet4'},
                        {'op': 'remove', 'path': '/ACL_TABLE/DATAACL/ports/0'},
                        {'op': 'remove', 'path': '/VLAN_MEMBER/Vlan1000|Ethernet8'},
                        {'op': 'remove', 'path': '/ACL_TABLE/EVERFLOWV6/ports/0'},
                        {'op': 'remove', 'path': '/ACL_TABLE/EVERFLOW/ports/0'},

                      {'op': 'remove', 'path': '/ACL_TABLE/EVERFLOWV6/ports/1'}])

tests/generic_config_updater/patch_sorter_test.py:1690:

---

tests/generic_config_updater/patch_sorter_test.py:1708: in verify
self.verify_moves(ex_ops, moves)
tests/generic_config_updater/patch_sorter_test.py:1712: in verify_moves
self.assertCountEqual(ex_ops, moves_ops)
E AssertionError: Element counts were not equal:
E First has 1, Second has 0: {'op': 'remove', 'path': '/VLAN_MEMBER/Vlan1000|Ethernet0'}
E First has 1, Second has 0: {'op': 'remove', 'path': '/VLAN_MEMBER/Vlan1000|Ethernet4'}
E First has 1, Second has 0: {'op': 'remove', 'path': '/VLAN_MEMBER/Vlan1000|Ethernet8'}
------- generated xml file: /sonic/src/sonic-utilities/test-results.xml --------

[zhangyanzhao]

LeafRef has a known issue which may be the root cause for the build failure. Try union leaf.

[ghooo]

One of the imports in the sonic-mclag.yang file might be breaking backlinks and hence breaking sonic-utilities UTs. It is a known problem, check issue #9312

[Praveen-Brcm]

Hi All the specific sonic yang files covers all the MCLAG configuration commands.

[arlakshm]

lgtm

[judyjoseph]

@gitsabari Please raise a separate PR for 202111 branch as there are merge conflicts.