[Services] Restart BGP service upon unexpected critical process exit. #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical processes crashed or exited unexpectedly. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
file. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
suggested changes
Feb 28, 2020
|
Yes, I will add that. |
of its processes crahsed or exited unexpectedly. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
of its critical processes crashed or exited unexpectedly. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
supervisord.conf file. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
|
@jleveque Please help me review these changes on gobgp and quagga. |
jleveque
suggested changes
Mar 2, 2020
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
suggested changes
Mar 2, 2020
rules/docker-fpm-quagga.mk and rules/docker-fpm-frr.mk. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
jleveque
approved these changes
Mar 4, 2020
rlhui
pushed a commit
that referenced
this pull request
Mar 4, 2020
pphuchar
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Mar 9, 2020
tiantianlv
pushed a commit
to SONIC-DEV/sonic-buildimage
that referenced
this pull request
Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Restart BGP service if one of critical processes running in BGP container exited or crashed abnormally.
How I did it
Generally I follow the framework created by Joe to implement this feature in BGP container.
First, add supervisor-proc-exit-listener event listener option in Supervisord configuration file in BGP docker container. Supervisord will read a list of critical processes for which to monitor the unexpected crashed and exited.
Second, configure bgp.service to always auto-restart the service if it stops, with a delay of 30 seconds. Also set a rate limit of 3 restarts within 20 minutes (1200 seconds).
How to verify it
On your switch device, please use
docker pscommand to list all running docker containers.Then use
docker exec -it container_id bashto login target container. Typingtopcommandon the shell will display all the processes dynamically and you will spot the process id of one
of the critical processes. Finally type the command
kill -9 process_idto terminate one process.After exiting the container, you can use
watch -n 1 docker psto dynamically see the restartof database container.