Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Services] Restart Teamd service upon unexpected critical process exit. #3703

Merged
merged 6 commits into from
Nov 5, 2019
Merged

[Services] Restart Teamd service upon unexpected critical process exit. #3703

merged 6 commits into from
Nov 5, 2019

Conversation

yozhao101
Copy link
Contributor

  • What I did
    Restart Teamd service if one of critical processes running in Teamd container exited or crashed abnormally.

  • How I did it
    Generally I follow the framework created by Joe to implement this feature in Teamd container.
    First, add supervisor-proc-exit-listener event listener option in Supervisord configuration file in Teamd docker container. Supervisord will read a list of critical processes for which to monitor the unexpected crashed and exited.
    Second, configure teamd.service to always auto-restart the service if it stops, with a delay of 30 seconds. Also set a rate limit of 3 restarts within 20 minutes (1200 seconds).

  • How to verify it
    On your switch device, please use docker ps command to list all running docker containers.
    Then use docker exec -it container_id bash to login target container. Typing top command
    on the shell will display all the processes dynamically and you will spot the process id of one
    of the critical processes. Finally type the command kill -9 process_id to terminate one process.
    After exiting the container, you can use watch -n 1 docker ps to dynamically see the restart
    of Teamd container.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
supervisord conf file.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
processes file into dockerfile.j2.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
to restart this container more than 3 times in 20 minutes.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
shared Makefile docker-teamd.mk.

Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants