Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to support sequential IDF isolation #19136

Merged
merged 1 commit into from
May 31, 2024

Conversation

tjchadaga
Copy link
Contributor

@tjchadaga tjchadaga commented May 30, 2024

Why I did it

In order to isolate an IDF sequentially (one device at a time), need a mechanism to perform downstream isolation on T2 device. Adding support for two kinds of isolation -

  1. By setting no-export BGP community on all routes advertised to T1 (except loopback), so the routes are not advertised to T0s
  2. By withdrawing all routes from T1
Work item tracking
  • Microsoft ADO (number only):

How I did it

Added

  1. New configuration to support the changes described by Yang model changes for Sequential IDF isolation #18597
  2. Script to update configDB on each ASIC to configure no-export/withdraw-all isolation and unisolation of IDF. This is copied to host
  3. BGPcfgd changes to handle configDB events and add/remove the required route-maps
  4. UT cases and data file changes for BGPCfgd and jinja templates

How to verify it

Corresponding templates on T2 have to be updated to verify the functionality

Configuration options-

  1. sudo idf_isolation withdraw_all
  2. sudo idf_isolation no-export
  3. sudo idf_isolation unisolated

Validate the routes on T1 are either withdrawn, tagged with no-export community or re-advertised based on the configuration

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@tjchadaga tjchadaga marked this pull request as ready for review May 30, 2024 15:15
@tjchadaga tjchadaga requested review from arlakshm and abdosi May 30, 2024 17:03
@tjchadaga
Copy link
Contributor Author

/azpw ms_conflict

@lguohan lguohan merged commit 3387506 into sonic-net:master May 31, 2024
20 checks passed
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
Why I did it
In order to isolate an IDF sequentially (one device at a time), need a mechanism to perform downstream isolation on T2 device. Adding support for two kinds of isolation -

By setting no-export BGP community on all routes advertised to T1 (except loopback), so the routes are not advertised to T0s By withdrawing all routes from T1

How I did it

Added

1. New configuration to support the changes described by Yang model changes for Sequential IDF isolation sonic-net#18597
Script to update configDB on each ASIC to configure no-export/withdraw-all isolation and unisolation of IDF. This is copied to host
2. BGPcfgd changes to handle configDB events and add/remove the required route-maps
3. UT cases and data file changes for BGPCfgd and jinja templates

How to verify it
Corresponding templates on T2 have to be updated to verify the functionality

Configuration options-

sudo idf_isolation withdraw_all
sudo idf_isolation no-export
sudo idf_isolation unisolated

Validate the routes on T1 are either withdrawn, tagged with no-export community or re-advertised based on the configuration
@tjchadaga tjchadaga added the Chassis for 202205 branch PRs needed for 202205 branch in msft repo label Jul 29, 2024
@rlhui rlhui removed the Chassis for 202205 branch PRs needed for 202205 branch in msft repo label Sep 6, 2024
@rlhui
Copy link
Contributor

rlhui commented Sep 6, 2024

this PR is not needed for msft 202205 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants