[enable_counters]: make enable_counter service depend on swss #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sihui Han <sihan@microsoft.com>
qiluo-msft
approved these changes
Jul 18, 2018
yxieca
approved these changes
Jul 18, 2018
|
retest this please |
pavel-shirshov
suggested changes
Jul 18, 2018
|
what we need:
|
|
Pavel is correct, and close the pr |
judyjoseph
added a commit
that referenced
this pull request
Aug 20, 2021
sonic-swss e892dda Fix warmboot issue PR##8367 (#1866) 9c6023d Mclag enhacements support code changes. (#1331) sonic-utilities 5465ea0 [MPLS][CLI] added config/show CLI for MPLS interface, MPLS CRM threshold config, updated CLI reference manual 3bac779 mclag enhancements as per HLD at sonic-net/SONiC#596 (#1138)
theasianpianist
pushed a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Feb 5, 2022
During the WB when the MAC addresses are added via refillToSync(&m_fdbStateTable) , the attribute SAI_FDB_ENTRY_ATTR_ALLOW_MAC_MOVE is set wrongly for dynamic MAC as well. Fix is to set SAI_FDB_ENTRY_ATTR_ALLOW_MAC_MOVE only for the case of VXLAN or MCLAG for fdb_type dyamic.
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
The race condition is caused by a blocking Redis call which gets the contents of the FDB entry from ASIC DB. Since it has been implemented as a simple loop, there is no guarantee that entry will be present in DB when the contents are being read. - What I did Fixed: [fdb] 'show mac' command failed with t0-56-po2vlan topology sonic-net#1866 - How I did it Removed blocking calls from fdbshow - How to verify it Run FDB test - Previous command output (if the output of a command-line utility has changed) root@sonic:/home/admin# show mac Key 'ASIC_STATE:SAI_OBJECT_TYPE_FDB_ENTRY:{"bvid":"oid:0x260000000009cc","mac":"02:11:22:33:20:00","switch_id":"oid:0x21000000000000"}' unavailable in database '1' - New command output (if the output of a command-line utility has changed) root@sonic:/home/admin# show mac No. Vlan MacAddress Port Type ----- ------ ------------ ------ ------ Total number of entries 0 Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihui Han sihan@microsoft.com
- What I did
Before the change enable_counter service will not start when using "service swss restart" or "config load_minigraph"
- How I did it
Modify the service file to make it depend on swss service
- How to verify it
With the change, run "service swss restart", "config load_minigraph", "systemctl restart swss",
Can see counters in counter db
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)