[Celestica] Make 'sfputil show presence' faster #18041
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The is_host function is used when enumerating SFPs which was very slow when detecting if it was running inside docker. The following call makes the detection 10x faster. Before patch: $ time sudo sfputil show presence Port Presence ----------- ----------- Ethernet0 Present Ethernet1 Present Ethernet2 Present -- snip -- real 0m13.521s user 0m10.239s sys 0m4.104s After patch: $ time sudo sfputil show presence Port Presence ----------- ----------- Ethernet0 Present Ethernet1 Present Ethernet2 Present -- snip -- real 0m2.133s user 0m1.461s sys 0m0.347s Signed-off-by: Tommy Nevtelen <tommy@nevtelen.com>
|
|
dal00
changed the title
8 tasks
qnos
approved these changes
Feb 21, 2024
|
@lguohan Is there still something needed before this can be reviewed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The is_host function is used when enumerating SFPs which was very slow when detecting if it was running inside docker. The following call makes the detection 10x faster.
How I did it
Instead of executing
dockercheck for/.dockerenvwhich is present when inside a container.How to verify it
Before patch:
After patch:
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
n/a
Link to config_db schema for YANG module changes
n/a
A picture of a cute animal (not mandatory but encouraged)