Event and alarm management #17949

bhaveshdell · 2024-01-30T21:10:56Z

Why I did it

This PR contains code changes for providing extension to the Event Framework as specified in the sonic-net/SONiC#1409

How I did it

Followed design specified in sonic-net/SONiC#1409.

How to verify it

Unit tests added.

A picture of a cute animal (not mandatory but encouraged)

remove ack, noack from sonic-common-event yang.

venkatmahalingam · 2024-02-02T03:58:50Z

src/sonic-yang-models/yang-models/sonic-event.yang

@@ -0,0 +1,134 @@
+  module sonic-event {


Would you add a code to call this event from one of the App to showcase the usage?

venkatmahalingam · 2024-02-02T04:01:34Z

src/sonic-eventd/src/eventconsume.h

@@ -0,0 +1,54 @@
+#ifndef __EVENTCONSUME_H__


I would like to see the existing event infra and this new changes work together in the unit test.

For example, if there is a BGP event, how does it get saved in the EVENT_DB.

UT code added with this PR.

shyam77git · 2024-02-11T20:06:18Z

dockers/docker-database/database_config.json.j2

+            "id" : 19,
+            "separator": "|",
+            "instance" : "redis"
+        }


This a new redis DB instance addition. Have few queries:

is there a max limit of redis DB instances that can be spawned and maintained on a given SONiC instance?

If so, was it ensured that its within limits and no impact to the overall system bring-up and working in steady state?

Is this a global database i.e. only a single instance of it would be spawned on the system in global namespace? or would it be one per ASIC/NPU namespace? Where is that determined/specified in this changeset?

Currently the max limit is set at 100 logical instances. /etc/redis/redis.conf

This is within the global database. (redis instance.)

bhaveshdell · 2024-04-10T01:44:47Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2024-04-10T01:44:50Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2024-04-10T01:45:01Z

Azure Pipelines successfully started running 1 pipeline(s).

bhaveshdell · 2024-05-13T16:45:23Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2024-05-13T16:45:29Z

Commenter does not have sufficient privileges for PR 17949 in repo sonic-net/sonic-buildimage

bhaveshdell · 2024-05-13T17:07:48Z

/azpw run Azure.sonic-buildimage

mssonicbld · 2024-05-13T17:07:50Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2024-05-13T17:08:01Z

Azure Pipelines successfully started running 1 pipeline(s).

Set eventdb testcases as separate test binary. Skip testcase execution if DB connection failure.

bhaveshdell · 2024-05-21T00:45:22Z

@bmridul @shyam77git @qiluo-msft Please review this PR.

zhangyanzhao · 2024-05-22T16:26:02Z

need more reviews

zhangyanzhao · 2024-05-30T06:38:02Z

@reviewers, can you please help to review this PR? Thanks.

adyeung · 2024-05-30T21:44:19Z

@leeprecy please help review

venkatmahalingam · 2024-07-31T04:35:24Z

@zhangyanzhao Can we merge this PR? or we need more approval?

venkatmahalingam · 2024-08-23T19:53:23Z

@lguohan @qiluo-msft @adyeung Can you review and merge the pull request?

adyeung · 2024-08-23T21:19:45Z

@Praveen-Brcm pls help review and merge

liushilongbuaa · 2024-08-27T05:11:30Z

@bhaveshdell , PR validation is too old. It run on May. Now it breaks vs build. LINK

Building target: eventd-tests
Invoking: G++ Linker
g++ -Wl,-z,relro -Wl,-z,now -o tests/tests ./src/eventd.o ./src/eventconsume.o ./src/eventutils.o ./src/loghandler.o ./tests/eventd_ut.o  ./tests/main.o  -levent -lhiredis -lswsscommon -lpthread -lboost_thread -lboost_system -lzmq -lboost_serialization -luuid -llua5.1 -L/usr/src/gtest -lgtest -lgtest_main -lgmock -lgmock_main
g++ -Wl,-z,relro -Wl,-z,now -o tests/eventdb ./src/eventd.o ./src/eventconsume.o ./src/eventutils.o ./src/loghandler.o ./tests/eventdb_ut.o -levent -lhiredis -lswsscommon -lpthread -lboost_thread -lboost_system -lzmq -lboost_serialization -luuid -llua5.1 -L/usr/src/gtest -lgtest -lgtest_main -lgmock -lgmock_main
/usr/bin/ld: ./tests/eventdb_ut.o: in function `std::__new_allocator<std::__detail::_Hash_node_base*>::allocate(unsigned long, void const*)':
/usr/include/c++/12/bits/new_allocator.h:125: undefined reference to `std::__throw_bad_array_new_length()'
/usr/bin/ld: /usr/include/c++/12/bits/new_allocator.h:125: undefined reference to `std::__throw_bad_array_new_length()'
/usr/bin/ld: /usr/include/c++/12/bits/new_allocator.h:125: undefined reference to `std::__throw_bad_array_new_length()'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:64: eventd-tests] Error 1
make[2]: *** Waiting for unfinished jobs....
Finished building: rsyslog_plugin/main.cpp
 
Finished building: rsyslog_plugin/rsyslog_plugin.cpp
 
Finished building: rsyslog_plugin_tests/rsyslog_plugin_ut.cpp
 
make[2]: Leaving directory '/sonic/src/sonic-eventd'
dh_auto_build: error: make -j4 "INSTALL=install --strip-program=true" returned exit code 2
make[1]: *** [debian/rules:6: build] Error 25
make[1]: Leaving directory '/sonic/src/sonic-eventd'
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
[  FAIL LOG END  ] [ target/debs/bullseye/sonic-eventd_1.0.0-0_amd64.deb ]

This reverts commit 10f0fe8.

bhaveshdell · 2024-08-28T17:56:18Z

@liushilongbuaa How can I commit the fix for the failure? Is the PR reverted?

This reverts commit 10f0fe8.

This reverts commit 93f3cad.

yxieca · 2024-08-28T20:09:41Z

@bhaveshdell your PR has been reverted as @liushilongbuaa pointed out.

I created a reversion of reversion PR #20064 , I suggest let's watch this PR build and test. Once the issue surfaced again, you can add more changed to 20064 to address the issue. Or you can create another PR, with your original change, plus change addressing the issue.

This reverts commit 93f3cad.

* Support for event persistence in redis-db. * Updates * Updates including fix to eventdb in test enviroment. * Add sonic yang to model event and alarm table. remove ack, noack from sonic-common-event yang. * Add event/alarm persistence related testscases * Remove file eventdb_ut.cpp. * Updates to eventdb testsuite. * Revert changes to existing eventd UT. Set eventdb testcases as separate test binary. Skip testcase execution if DB connection failure. * Commit test related config files.

This reverts commit 10f0fe8.

bhaveshdell added 3 commits January 24, 2024 14:25

Support for event persistence in redis-db.

20ec442

Updates

b314160

Updates including fix to eventdb in test enviroment.

e724cb4

bhaveshdell requested review from qiluo-msft and lguohan as code owners January 30, 2024 21:10

This was referenced Jan 30, 2024

Event/alarm framework HLD update. Integrate with event producer framework. sonic-net/SONiC#1409

Merged

Event and alarm management: Add tables for event and alarms. sonic-net/sonic-swss-common#852

Merged

Add sonic yang to model event and alarm table.

4a6ccdb

remove ack, noack from sonic-common-event yang.

venkatmahalingam reviewed Feb 2, 2024

View reviewed changes

shyam77git reviewed Feb 11, 2024

View reviewed changes

Add event/alarm persistence related testscases

28656eb

venkatmahalingam approved these changes May 14, 2024

View reviewed changes

bhaveshdell added 4 commits May 16, 2024 10:10

Remove file eventdb_ut.cpp.

eca9741

Updates to eventdb testsuite.

c9ab66d

Revert changes to existing eventd UT.

048a056

Set eventdb testcases as separate test binary. Skip testcase execution if DB connection failure.

Commit test related config files.

cdfe814

jeff-yin requested a review from adyeung May 29, 2024 23:18

leeprecy approved these changes Jul 30, 2024

View reviewed changes

Praveen-Brcm approved these changes Aug 23, 2024

View reviewed changes

Praveen-Brcm merged commit 10f0fe8 into sonic-net:master Aug 23, 2024
20 checks passed

liushilongbuaa added a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 28, 2024

Revert "Event and alarm management (sonic-net#17949)"

b29186b

This reverts commit 10f0fe8.

yxieca pushed a commit that referenced this pull request Aug 28, 2024

Revert "Event and alarm management (#17949)" (#20052)

93f3cad

This reverts commit 10f0fe8.

yxieca added a commit that referenced this pull request Aug 28, 2024

Revert "Revert "Event and alarm management (#17949)" (#20052)"

899b459

This reverts commit 93f3cad.

liushilongbuaa added a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 29, 2024

Reapply "Event and alarm management (sonic-net#17949)" (sonic-net#20052)

20a9e04

This reverts commit 93f3cad.

liushilongbuaa added a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 30, 2024

Reapply "Event and alarm management (sonic-net#17949)" (sonic-net#20052)

34080ec

This reverts commit 93f3cad.

liushilongbuaa added a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 30, 2024

Reapply "Event and alarm management (sonic-net#17949)" (sonic-net#20052)

8a65482

This reverts commit 93f3cad.

vvolam pushed a commit to vvolam/sonic-buildimage that referenced this pull request Sep 12, 2024

Revert "Event and alarm management (sonic-net#17949)" (sonic-net#20052)

3b01cf7

This reverts commit 10f0fe8.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Event and alarm management #17949

Event and alarm management #17949

bhaveshdell commented Jan 30, 2024 •

edited

Loading

venkatmahalingam Feb 2, 2024

venkatmahalingam Feb 2, 2024

bhaveshdell May 13, 2024

shyam77git Feb 11, 2024

bhaveshdell Feb 12, 2024

bhaveshdell commented Apr 10, 2024

mssonicbld commented Apr 10, 2024

azure-pipelines bot commented Apr 10, 2024

bhaveshdell commented May 13, 2024

azure-pipelines bot commented May 13, 2024

bhaveshdell commented May 13, 2024

mssonicbld commented May 13, 2024

azure-pipelines bot commented May 13, 2024

bhaveshdell commented May 21, 2024

zhangyanzhao commented May 22, 2024

zhangyanzhao commented May 30, 2024

adyeung commented May 30, 2024

venkatmahalingam commented Jul 31, 2024

venkatmahalingam commented Aug 23, 2024

adyeung commented Aug 23, 2024

liushilongbuaa commented Aug 27, 2024 •

edited

Loading

bhaveshdell commented Aug 28, 2024

yxieca commented Aug 28, 2024

Event and alarm management #17949

Event and alarm management #17949

Conversation

bhaveshdell commented Jan 30, 2024 • edited Loading

Why I did it

How I did it

How to verify it

A picture of a cute animal (not mandatory but encouraged)

venkatmahalingam Feb 2, 2024

Choose a reason for hiding this comment

venkatmahalingam Feb 2, 2024

Choose a reason for hiding this comment

bhaveshdell May 13, 2024

Choose a reason for hiding this comment

shyam77git Feb 11, 2024

Choose a reason for hiding this comment

bhaveshdell Feb 12, 2024

Choose a reason for hiding this comment

bhaveshdell commented Apr 10, 2024

mssonicbld commented Apr 10, 2024

azure-pipelines bot commented Apr 10, 2024

bhaveshdell commented May 13, 2024

azure-pipelines bot commented May 13, 2024

bhaveshdell commented May 13, 2024

mssonicbld commented May 13, 2024

azure-pipelines bot commented May 13, 2024

bhaveshdell commented May 21, 2024

zhangyanzhao commented May 22, 2024

zhangyanzhao commented May 30, 2024

adyeung commented May 30, 2024

venkatmahalingam commented Jul 31, 2024

venkatmahalingam commented Aug 23, 2024

adyeung commented Aug 23, 2024

liushilongbuaa commented Aug 27, 2024 • edited Loading

bhaveshdell commented Aug 28, 2024

yxieca commented Aug 28, 2024

bhaveshdell commented Jan 30, 2024 •

edited

Loading

liushilongbuaa commented Aug 27, 2024 •

edited

Loading