Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lldpmgrd] Fix potential race condition when interfaces are created #1469

Merged
merged 4 commits into from
Mar 8, 2018
Merged

[lldpmgrd] Fix potential race condition when interfaces are created #1469

merged 4 commits into from
Mar 8, 2018

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Mar 7, 2018

- What I did

  • Patch lldpctl/lldpcli so that it returns an error code if specified port doesn't exist
    • Removed lldpd submodule; now cloning source repo and applying patch during build
  • Add retry logic to lldpmgrd so that it will continually retry lldpcli commands which return an error code
  • Cause swsscommon select() call to timeout after 10 seconds in order to periodically force a retry of any queued-up (i.e., previously failed) commands.

@jleveque jleveque self-assigned this Mar 7, 2018
@jleveque jleveque requested a review from lguohan March 7, 2018 20:01
@jleveque jleveque merged commit c161de4 into sonic-net:master Mar 8, 2018
@jleveque jleveque deleted the lldpmgrd_race_cond_fix branch March 8, 2018 01:08
@stcheng
Copy link
Contributor

stcheng commented Mar 8, 2018

💯

@jleveque jleveque mentioned this pull request Aug 24, 2018
Closed
@daall daall mentioned this pull request Oct 26, 2020
Merged
3 tasks
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Mar 4, 2021
@yxieca
[202012][swss][utilities] advance submodule head
bcca2a5 
swss:
* c712c24 2021-03-04 | Update StateDB with error if state change failed, Update APP_DB in all state chg req (sonic-net#1662) (HEAD -> 202012) [Prince Sunny]

utilities:
* 9a9bff4 2021-03-03 | [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475) (HEAD -> 202012) [Danny Allen]
* d1e7d4e 2021-03-04 | [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470) [Junchao-Mellanox]
* a1df1b4 2021-03-03 | [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469) [Danny Allen]
* bab4a23 2021-03-03 | [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465) [Lawrence Lee]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca mentioned this pull request Mar 4, 2021
Merged
yxieca added a commit that referenced this pull request Mar 5, 2021
@yxieca
[202012][swss][utilities] advance submodule head (#6969)
30e9f02 
swss:
* c712c24 2021-03-04 | Update StateDB with error if state change failed, Update APP_DB in all state chg req (#1662) (HEAD -> 202012) [Prince Sunny]

utilities:
* 9a9bff4 2021-03-03 | [acl] Expand VLAN into VLAN members when creating an ACL table (#1475) (HEAD -> 202012) [Danny Allen]
* d1e7d4e 2021-03-04 | [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (#1470) [Junchao-Mellanox]
* a1df1b4 2021-03-03 | [acl-loader] Add support for matching on ICMP and VLAN info (#1469) [Danny Allen]
* bab4a23 2021-03-03 | [config reload]: On dual ToR systems, cache ARP and FDB tables (#1465) [Lawrence Lee]

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@vdahiya12 vdahiya12 mentioned this pull request Mar 9, 2021
Merged
4 tasks
vdahiya12 added a commit that referenced this pull request Mar 10, 2021
@vdahiya12
[sonic-utilities] submodule update (#6992)
ddf51c7 
this PR updates the following commits in sonic-utilities

13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (#1467)
f78e7ce [acl-loader] Improve input validation for acl_loader (#1479)
748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (#1368)
64604db [acl] Expand VLAN into VLAN members when creating an ACL table (#1475)
10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (#1465)
10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (#1470)
38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (#1469)
e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (#1380)
4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (#1471)
dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (#1460)
e32b5ac Add soft-reboot reboot type (#1453)
8b3bc18 [reload] Improve reload by using sonic.target. (#1199)
99673bc [reboot] Add platform-specific reboot cause update hook (#1454)
2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (#1445)
1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (#1416)
79ccd03 [show] cli support for show muxcable cableinfo (#1448)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 10, 2021
@daall
[acl-loader] Add support for matching on ICMP and VLAN info (sonic-ne…
38c8e00 
…t#1469)

- Add ICMP and VLAN fields
- Add new unit test cases

Signed-off-by: Danny Allen <daall@microsoft.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
@vdahiya12 @raphaelt-nvidia
[sonic-utilities] submodule update (sonic-net#6992)
433a4f4 
this PR updates the following commits in sonic-utilities

13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (sonic-net#1467)
f78e7ce [acl-loader] Improve input validation for acl_loader (sonic-net#1479)
748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (sonic-net#1368)
64604db [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475)
10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465)
10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470)
38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469)
e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (sonic-net#1380)
4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (sonic-net#1471)
dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460)
e32b5ac Add soft-reboot reboot type (sonic-net#1453)
8b3bc18 [reload] Improve reload by using sonic.target. (sonic-net#1199)
99673bc [reboot] Add platform-specific reboot cause update hook (sonic-net#1454)
2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445)
1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (sonic-net#1416)
79ccd03 [show] cli support for show muxcable cableinfo (sonic-net#1448)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@vdahiya12
[sonic-utilities] submodule update (sonic-net#6992)
7463823 
this PR updates the following commits in sonic-utilities

13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (sonic-net#1467)
f78e7ce [acl-loader] Improve input validation for acl_loader (sonic-net#1479)
748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (sonic-net#1368)
64604db [acl] Expand VLAN into VLAN members when creating an ACL table (sonic-net#1475)
10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (sonic-net#1465)
10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (sonic-net#1470)
38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (sonic-net#1469)
e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (sonic-net#1380)
4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (sonic-net#1471)
dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460)
e32b5ac Add soft-reboot reboot type (sonic-net#1453)
8b3bc18 [reload] Improve reload by using sonic.target. (sonic-net#1199)
99673bc [reboot] Add platform-specific reboot cause update hook (sonic-net#1454)
2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (sonic-net#1445)
1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (sonic-net#1416)
79ccd03 [show] cli support for show muxcable cableinfo (sonic-net#1448)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
@qiluo-msft
Add missing lib for lgtm (sonic-net#1469)
f2ad8f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels
Bug 🐛 Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jleveque @stcheng @lguohan