SONiC YANG model for RADIUS. #12749

shdasari · 2022-11-18T06:17:51Z

Why I did it

Added SONiC YANG model for RADIUS.
Fixes #12477

How I did it

Added the RADIUS and RADIUS_SERVER tables for global and per RADIUS server configuration. RADIUS statistics reside in COUNTERS_DB and are not part of the configuration. These are not a part of this PR.

How to verify it

Compiled sonic_yang_mgmt-1.0-py3-none-any.whl.

Which release branch to backport (provide reason below if selected)

Description for the changelog

SONiC YANG model for RADIUS.

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

linux-foundation-easycla · 2022-11-18T06:17:54Z

The committers listed above are authorized under a signed CLA.

✅ login: shdasari (f83e794)

ganglyu · 2022-11-22T04:30:14Z

Would you please update doc/Configuration.md?

shdasari · 2022-11-22T09:42:56Z

Updated Configuration.md.

zhangyanzhao · 2022-12-08T18:22:52Z

@isabelmsft @praveen-li @qiluo-msft can you please help to review this PR? Thanks.

isabelmsft · 2022-12-09T05:00:22Z

/azp run

azure-pipelines · 2022-12-09T05:00:27Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

isabelmsft · 2022-12-09T05:38:57Z

@shdasari Looks like build is failing, can we make sure to pass the PR checker?

shdasari · 2022-12-09T05:45:31Z

@shdasari Looks like build is failing, can we make sure to pass the PR checker?

Sure, let me get it resolved.

Checked, and it looks like "make configure" is failing and this does not have anything to do with the YANG changes.

docker create --name sonic-slave-bullseye-6f382ea8eee --entrypoint /bin/bash sonic-slave-bullseye:6f382ea8eee
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
docker cp -L sonic-slave-bullseye-6f382ea8eee:/etc/os-release target/versions/dockers/sonic-slave-bullseye/
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
docker cp -L sonic-slave-bullseye-6f382ea8eee:/usr/local/share/buildinfo/pre-versions target/versions/dockers/sonic-slave-bullseye/
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
docker cp -L sonic-slave-bullseye-6f382ea8eee:/usr/local/share/buildinfo/post-versions target/versions/dockers/sonic-slave-bullseye/
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
IMAGENAME=sonic-slave-bullseye:6f382ea8eee
j2 files/build_templates/build_docker_cache.j2
docker tag sonic-slave-bullseye:6f382ea8eee tmp-sonic-slave-bullseye:6f382ea8eee
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
DOCKER_BUILDKIT=1
docker build -f sonic-slave-bullseye/Dockerfile.cleanup --target output -o target/vcache/sonic-slave-bullseye sonic-slave-bullseye
failed to dial gRPC: cannot connect to the Docker daemon. Is 'docker daemon' running on this host?: dial unix /var/run/docker.sock: connect: connection refused
DOCKER_BUILDKIT=1
docker build -f sonic-slave-bullseye/Dockerfile.cleanup --no-cache --target final --tag sonic-slave-bullseye:6f382ea8eee sonic-slave-bullseye
failed to dial gRPC: cannot connect to the Docker daemon. Is 'docker daemon' running on this host?: dial unix /var/run/docker.sock: connect: connection refused
docker rmi tmp-sonic-slave-bullseye:6f382ea8eee
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
docker container rm sonic-slave-bullseye-6f382ea8eee
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
make[1]: *** [Makefile.work:539: configure] Error 1
make[1]: Leaving directory '/data/myagent/_work/27/s'
make: *** [Makefile:93: configure] Error 2
##[error]Bash exited with code '2'.
Finishing: Make configure

Not sure if this has anything to do with privileges.

shdasari · 2022-12-09T08:22:04Z

/azp run all

azure-pipelines · 2022-12-09T08:22:14Z

Commenter does not have sufficient privileges for PR 12749 in repo sonic-net/sonic-buildimage

zhangyanzhao · 2022-12-15T17:21:32Z

@shdasari can you please help to check the build failure? Once the build passed, we can merge.

wen587 · 2022-12-16T01:55:45Z

I suspect libyang backlink issue.

Take this failed test as example: test_find_ref_paths__path_is_table__returns_ref_paths

2022-12-15T07:27:30.8137237Z E         ['/ACL_TABLE/DATAACL/ports/0',
2022-12-15T07:27:30.8137717Z E          '/ACL_TABLE/EVERFLOW/ports/0',
2022-12-15T07:27:30.8138209Z E          '/ACL_TABLE/EVERFLOWV6/ports/0',
2022-12-15T07:27:30.8138709Z E          '/ACL_TABLE/EVERFLOWV6/ports/1',
2022-12-15T07:27:30.8139216Z E       -  '/ACL_TABLE/NO-NSW-PACL-V4/ports/0',
2022-12-15T07:27:30.8139561Z E       ?                                     ^
2022-12-15T07:27:30.8139812Z E       
2022-12-15T07:27:30.8140252Z E       +  '/ACL_TABLE/NO-NSW-PACL-V4/ports/0']
2022-12-15T07:27:30.8140585Z E       ?                                     ^
2022-12-15T07:27:30.8141019Z E       
2022-12-15T07:27:30.8141499Z E       -  '/VLAN_MEMBER/Vlan1000|Ethernet0',       <<=== missing VLAN_MEMBER 
2022-12-15T07:27:30.8142026Z E       -  '/VLAN_MEMBER/Vlan1000|Ethernet4',       <<=== missing VLAN_MEMBER
2022-12-15T07:27:30.8142539Z E       -  '/VLAN_MEMBER/Vlan1000|Ethernet8']       <<=== missing VLAN_MEMBER

After adding this YANG model, it loses VLAN_MEMBER ref path.
Though the RADIUS yang model is not related to this test, it breaks the ref pathfinding for other YANG models.

I am afraid GCU feature will be broken if we merge this PR.

I think @li-pingmao is working to upgrade libyang to libyang2. But libyang2 is missing many APIs that sonic_yang has been using. So the work is not completed yet.

@qiluo-msft for vis.

ganglyu · 2022-12-16T02:33:08Z

I suspect libyang backlink issue.

Take this failed test as example: test_find_ref_paths__path_is_table__returns_ref_paths
2022-12-15T07:27:30.8137237Z E         ['/ACL_TABLE/DATAACL/ports/0',
2022-12-15T07:27:30.8137717Z E          '/ACL_TABLE/EVERFLOW/ports/0',
2022-12-15T07:27:30.8138209Z E          '/ACL_TABLE/EVERFLOWV6/ports/0',
2022-12-15T07:27:30.8138709Z E          '/ACL_TABLE/EVERFLOWV6/ports/1',
2022-12-15T07:27:30.8139216Z E       -  '/ACL_TABLE/NO-NSW-PACL-V4/ports/0',
2022-12-15T07:27:30.8139561Z E       ?                                     ^
2022-12-15T07:27:30.8139812Z E       
2022-12-15T07:27:30.8140252Z E       +  '/ACL_TABLE/NO-NSW-PACL-V4/ports/0']
2022-12-15T07:27:30.8140585Z E       ?                                     ^
2022-12-15T07:27:30.8141019Z E       
2022-12-15T07:27:30.8141499Z E       -  '/VLAN_MEMBER/Vlan1000|Ethernet0',       <<=== missing VLAN_MEMBER 
2022-12-15T07:27:30.8142026Z E       -  '/VLAN_MEMBER/Vlan1000|Ethernet4',       <<=== missing VLAN_MEMBER
2022-12-15T07:27:30.8142539Z E       -  '/VLAN_MEMBER/Vlan1000|Ethernet8']       <<=== missing VLAN_MEMBER
After adding this YANG model, it loses VLAN_MEMBER ref path. Though the RADIUS yang model is not related to this test, it breaks the ref pathfinding for other YANG models.

I am afraid GCU feature will be broken if we merge this PR.

I think @li-pingmao is working to upgrade libyang to libyang2. But libyang2 is missing many APIs that sonic_yang has been using. So the work is not completed yet.

@qiluo-msft for vis.

Only armhf pipeline detects this error, does it mean libyang behavior is different on armhf platform?

wen587 · 2023-01-09T08:26:25Z

src/sonic-yang-models/yang-models/sonic-system-radius.yang

+        prefix lag;
+    }
+
+    import sonic-vlan {


Hi @shdasari , you may need to comment out vlan import. As it will break libyang backlinks. Issue can be tracked here: #9312

Sure, will upload a new set of diffs with the changes commented out.

mssonicbld · 2023-01-20T21:37:58Z

@shdasari PR conflicts with 202205 branch

yxieca · 2023-02-09T21:35:44Z

@adyeung can you help ping @shdasari to create 202205 PR?

adyeung · 2023-02-10T21:17:40Z

shdasari will post a new PR for 202205

SONiC YANG model for RADIUS.

f83e794

shdasari requested a review from qiluo-msft as a code owner November 18, 2022 06:17

lguohan added the YANG YANG model related changes label Nov 19, 2022

qiluo-msft requested review from ganglyu, praveen-li and isabelmsft November 22, 2022 05:11

Update Configuration.md

bdd3732

ganglyu approved these changes Dec 9, 2022

View reviewed changes

sonic-net deleted a comment from azure-pipelines bot Dec 9, 2022

Update radius.json

ee63dc7

qiluo-msft assigned wen587 Dec 23, 2022

wen587 reviewed Jan 9, 2023

View reviewed changes

SONiC YANG model for RADIUS.

bf242b9

wen587 approved these changes Jan 10, 2023

View reviewed changes

qiluo-msft approved these changes Jan 12, 2023

View reviewed changes

qiluo-msft merged commit 97161ae into sonic-net:master Jan 12, 2023

zhangyanzhao added Request for 202205 Branch Request for 202111 Branch For PRs being requested for 202111 branch labels Jan 19, 2023

yxieca added the Approved for 202205 Branch label Jan 20, 2023

mssonicbld added the Cherry Pick Conflict_202205 label Jan 20, 2023

adyeung mentioned this pull request Jan 20, 2023

SONiC YANG RADIUS Server and RADIUS table sonic-net/SONiC#1182

Closed

yxieca mentioned this pull request Feb 10, 2023

SONiC YANG model support for RADIUS. #13760

Merged

8 tasks

yxieca added the Included in 202205 Branch label Feb 10, 2023

isabelmsft mentioned this pull request Apr 6, 2023

[yang] add NEIGH yang model #14521

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SONiC YANG model for RADIUS. #12749

SONiC YANG model for RADIUS. #12749

shdasari commented Nov 18, 2022 •

edited by qiluo-msft

Loading

linux-foundation-easycla bot commented Nov 18, 2022 •

edited

Loading

ganglyu commented Nov 22, 2022

shdasari commented Nov 22, 2022

zhangyanzhao commented Dec 8, 2022

isabelmsft commented Dec 9, 2022

azure-pipelines bot commented Dec 9, 2022

isabelmsft commented Dec 9, 2022

shdasari commented Dec 9, 2022 •

edited

Loading

shdasari commented Dec 9, 2022

azure-pipelines bot commented Dec 9, 2022

zhangyanzhao commented Dec 15, 2022

wen587 commented Dec 16, 2022

ganglyu commented Dec 16, 2022

wen587 Jan 9, 2023

shdasari Jan 9, 2023

mssonicbld commented Jan 20, 2023

yxieca commented Feb 9, 2023

adyeung commented Feb 10, 2023

SONiC YANG model for RADIUS. #12749

SONiC YANG model for RADIUS. #12749

Conversation

shdasari commented Nov 18, 2022 • edited by qiluo-msft Loading

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

linux-foundation-easycla bot commented Nov 18, 2022 • edited Loading

ganglyu commented Nov 22, 2022

shdasari commented Nov 22, 2022

zhangyanzhao commented Dec 8, 2022

isabelmsft commented Dec 9, 2022

azure-pipelines bot commented Dec 9, 2022

isabelmsft commented Dec 9, 2022

shdasari commented Dec 9, 2022 • edited Loading

shdasari commented Dec 9, 2022

azure-pipelines bot commented Dec 9, 2022

zhangyanzhao commented Dec 15, 2022

wen587 commented Dec 16, 2022

ganglyu commented Dec 16, 2022

wen587 Jan 9, 2023

Choose a reason for hiding this comment

shdasari Jan 9, 2023

Choose a reason for hiding this comment

mssonicbld commented Jan 20, 2023

yxieca commented Feb 9, 2023

adyeung commented Feb 10, 2023

shdasari commented Nov 18, 2022 •

edited by qiluo-msft

Loading

linux-foundation-easycla bot commented Nov 18, 2022 •

edited

Loading

shdasari commented Dec 9, 2022 •

edited

Loading