Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-host-services]: Fix import and invalid path #10660

Merged
merged 5 commits into from
Apr 26, 2022

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented Apr 24, 2022

Why I did it

Can not start sonic-hostservice

How I did it

Install python3-dbus and systemd-python, and replace invalid path

How to verify it

Start the service with below commands:
sudo systemctl start sonic-hostservice
sudo systemctl status sonic-hostservice

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Fix #10647

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@ganglyu ganglyu requested a review from qiluo-msft April 24, 2022 06:02
@ganglyu ganglyu requested a review from lguohan as a code owner April 24, 2022 06:02
@ganglyu ganglyu requested a review from qiluo-msft April 24, 2022 06:42
@ganglyu ganglyu requested a review from qiluo-msft April 24, 2022 09:11
@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2022

This pull request introduces 1 alert when merging 2e78e3c into 5cd6bc4 - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

try:
from host_modules import host_service
return os.path.dirname(host_service.__file__)
except Exception as e:
Copy link
Collaborator

@qiluo-msft qiluo-msft Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception

Use more specific exception type, otherwise, it may hide bug, such as syntax error. #Closed

from host_modules import host_service
return os.path.dirname(host_service.__file__)
except Exception as e:
print("error occurred in find_module_path: {}".format(sys.exc_info()[1]))
Copy link
Collaborator

@qiluo-msft qiluo-msft Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print

Normally do not print inside a general function. If you really want to print, you may call it and check return value. So the print will be in main function. #Closed

@ganglyu ganglyu requested a review from qiluo-msft April 26, 2022 00:13
@ganglyu
Copy link
Contributor Author

ganglyu commented Apr 26, 2022

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ganglyu ganglyu merged commit 9d7387a into sonic-net:master Apr 26, 2022
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 20, 2022
Related work items: #49, #58, #107, sonic-net#247, sonic-net#249, sonic-net#277, sonic-net#593, sonic-net#597, sonic-net#1035, sonic-net#2130, sonic-net#2150, sonic-net#2165, sonic-net#2169, sonic-net#2178, sonic-net#2179, sonic-net#2187, sonic-net#2188, sonic-net#2191, sonic-net#2195, sonic-net#2197, sonic-net#2198, sonic-net#2200, sonic-net#2202, sonic-net#2206, sonic-net#2209, sonic-net#2211, sonic-net#2216, sonic-net#7909, sonic-net#8927, sonic-net#9681, sonic-net#9733, sonic-net#9746, sonic-net#9850, sonic-net#9967, sonic-net#10104, sonic-net#10152, sonic-net#10168, sonic-net#10228, sonic-net#10266, sonic-net#10288, sonic-net#10294, sonic-net#10313, sonic-net#10394, sonic-net#10403, sonic-net#10404, sonic-net#10421, sonic-net#10431, sonic-net#10437, sonic-net#10445, sonic-net#10457, sonic-net#10458, sonic-net#10465, sonic-net#10467, sonic-net#10469, sonic-net#10470, sonic-net#10474, sonic-net#10477, sonic-net#10478, sonic-net#10482, sonic-net#10485, sonic-net#10488, sonic-net#10489, sonic-net#10492, sonic-net#10494, sonic-net#10498, sonic-net#10501, sonic-net#10509, sonic-net#10512, sonic-net#10514, sonic-net#10516, sonic-net#10517, sonic-net#10523, sonic-net#10525, sonic-net#10531, sonic-net#10532, sonic-net#10538, sonic-net#10555, sonic-net#10557, sonic-net#10559, sonic-net#10561, sonic-net#10565, sonic-net#10572, sonic-net#10574, sonic-net#10576, sonic-net#10578, sonic-net#10581, sonic-net#10585, sonic-net#10587, sonic-net#10599, sonic-net#10607, sonic-net#10611, sonic-net#10616, sonic-net#10618, sonic-net#10619, sonic-net#10623, sonic-net#10624, sonic-net#10633, sonic-net#10646, sonic-net#10655, sonic-net#10660, sonic-net#10664, sonic-net#10680, sonic-net#10683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not start sonic-hostservice
3 participants