Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-cfggen] Minigraph parser must generate port lanes and speed #9676

Closed
ganglyu opened this issue Jan 5, 2022 · 1 comment · Fixed by #10228
Closed

[sonic-cfggen] Minigraph parser must generate port lanes and speed #9676

ganglyu opened this issue Jan 5, 2022 · 1 comment · Fixed by #10228
Assignees
Labels
sonic-cfggen SONiC Configuration Generator Tool Triaged this issue has been triaged YANG YANG model related changes

Comments

@ganglyu
Copy link
Contributor

ganglyu commented Jan 5, 2022

Description

Please refer to #9553
Config db schema generated by minigraph can’t pass yang validation, PORT table does not have 'lanes' field.
We will add a new constraint for minigraph parser: if PORT table does not have 'lanes' field, minigraph parser will raise an exception.
When we invoke sonic-cfggen, must provide '-p' or '-S' for minigraph parser to make sure PORT table has 'lanes' field.
https://github.com/Azure/sonic-buildimage/blob/master/files/image_config/topology/topology.sh#L14
Above line should be updated to use '-p' or '-S' to provide port_config.ini or platform.json, so that new constraint will not block anything.

Steps to reproduce the issue:

  1. Run command 'sonic-cfggen -m xxx.xml --print-data', and make sure config_db does not proivde lanes.
  2. Check command output.

Describe the results you received:

sonic-cfggen can generate config db schema, and there's no lanes field in PORT table.

Describe the results you expected:

sonic-cfggen should raise an exception.

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

@ganglyu ganglyu added the sonic-cfggen SONiC Configuration Generator Tool label Jan 5, 2022
@yxieca yxieca added the Triaged this issue has been triaged label Jan 5, 2022
@ganglyu ganglyu added the YANG YANG model related changes label Jan 6, 2022
@ganglyu ganglyu assigned wen587 and unassigned SuvarnaMeenakshi and ganglyu Mar 28, 2022
@ganglyu ganglyu changed the title [sonic-cfggen] Minigraph parser must generate port lanes [sonic-cfggen] Minigraph parser must generate port lanes and speed Apr 7, 2022
@qiluo-msft
Copy link
Collaborator

@ganglyu The fixing PR is reverted. Should we reopen this issue? Is it still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sonic-cfggen SONiC Configuration Generator Tool Triaged this issue has been triaged YANG YANG model related changes
Projects
None yet
5 participants