Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[warm restart] code refactoring to improve service container warm resart #665

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[warm restart] code refactoring to improve service container warm resart #665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions doc/warm-reboot/SONiC_Warmboot.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ Table of Contents
* [Approach evaluation](#approach-evaluation-1)
* [Advantages](#advantages-1)
* [Concerns/Issues with this approach](#concernsissues-with-this-approach-1)
* [Service container warm restart](#service-container-warm-restart)
* [Open issues](#open-issues)
* [How to do version control for software upgrade at docker level?](#how-to-do-version-control-for-software-upgrade-at-docker-level)
* [Rollback support in SONiC](#rollback-support-in-sonic)
Expand Down Expand Up @@ -326,6 +327,18 @@ One possible but kind of extreme solution is: Always flush all related appDB tab
* Warm restart of upper layer applications closely coupled with syncd.
* Various corner cases from SAI object model and changes in SAI object model itself have to be handled.

# Service container warm restart
* Service container warm restrt is the fundation of warm reboot. It is generally supported already.
* Code clean up to improve use-ability of service container warm restart is needed.
* Scope: swss, syncd, bgp, teamd, radv.
* Goals:
* Encapculate warm shutdown/recover knowledge in service script instead of warm-reboot script.
* Each service script handles how to stop / start service in warm / fast /cold scenarios.
* The warm-reboot script handles the ordering of service shutdown and reboot.
* Exception:
* syncd pre-shutdown is only needed for warm reboot. This behavior stays in warm-reboot script.
* Configuration to enable service container warm restart stays outside the service scripts.

# Open issues

## How to do version control for software upgrade at docker level?
Expand Down