SRv6 VPN HLD for 202305 release #1252
Conversation
|
Community review recording link https://zoom.us/rec/share/GKVyYm-Fifb2AX1NQs0GmRxbpk0RsCHKGGQs8oA0lue10IM8IfwYYcTQraD2KdVl.Xevxz68j4jwlxRem |
There was a problem hiding this comment.
In current SRv6 implementation the SRv6Orch creates the nexthop. This is because we did not have SRv6 support in FRR then and assumption is configuration is controller driven path which adds the SRv6 routes into APP_DB. As we integrate the new FRR SRv6 support into SONiC as in this PR, the nexthop/group creation can now be leveraged from the FRR route addition path RouteOrch. SRv6Orch will continue to do other tasks for MY_SID and SRv6 policy -processing,
doc/srv6/srv6_vpn.md
Outdated
| segment = SRV6_SID_LIST.key ; New optional field. List of segment names, separated by ',' | ||
| seg_src = address ; New optional field. Source addrs for sid encap | ||
| vpn_sid = vpn_sid ; New optional field to add vpn_sid to learnt BGP routes | ||
| policy = policy ; New optional field to add policy name to learnt BGP routes |
There was a problem hiding this comment.
as mentioned above, I am not sure if policy should really belong to orchagent.. There is no policy notion in orchagent for regular routing
There was a problem hiding this comment.
I quote @reshmaintel 's previous comments here "SRv6Orch will continue to do other tasks for MY_SID and SRv6 policy -processing," . The current thought process is to continue with current design. We could discuss this topic in routing WG if you want.
For 202205, we will upstream SRv6 VPN only. Policy will come in the future release.
|
Hi @eddieruan-alibaba, |
|
@prsunny @shay-zadok @venkatmahalingam @reshmaintel @kafka-soda @svshah-intel @kperumalbfn reviewers, would you please take time to finish your review? It is not mandatory to get approval from all reviewers to merge the PR. Thanks. |
Wondering if we need to approve as is or discuss further to understand the workarounds/deviations mentioned in this HLD in the separate work-group and then update this document as needed for final approval. |
|
@eddieruan-alibaba can you please list the code PRs to this HLD by referring to #806 |
|
@eddieruan-alibaba can you please help to add the code PRs to this HLD by referring to #806 ? Thanks. |
Added. But how to add a url to display PR status here? Any suggestions? @zhangyanzhao |
|
Can this PR be merged? Also please help on the code PR review. |
I saw you added " I have added code PRs in this PR. |
|
@eddieruan-alibaba the FRR PRs need be reviewed in FRR community, are those required by your feature? |
|
@eddieruan-alibaba , do we have sonic-mgmt test plan for this feature? |
They have missed the train to go into 202305 release. These PRs could be patched in 202305 for the POC purpose. These FRR PRs would go to FRR community and come in to 202311 once we move FRR ref point for 202311. |
Hanyu from my team has created a PR for SONiC CLI changes and explained the information to check. The headache is that we don't have software or hardware platform for the test. I am working with Praveen from Cisco to see if we could add Cisco C8K as a hardware platform for this feature in public. |
|
code PRs are not merged yet |
SRv6 VPN HLD for 202305 release
The PR would be merged to 202305 release
The PR would be outstanding for 202305 release, a.k.a coming in 202311
These PRs are either missed FRR train or need to finalize in routing WG. The purposes for these PRs are for people to use 202305 for SRv6 VPN PoC.