Link event damping HLD #1071
Merged
Link event damping HLD #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Ashish1805
force-pushed
the
ashish_LE
branch
from
f155e8e
to
b639396
Compare
Ashish1805
force-pushed
the
ashish_LE
branch
2 times, most recently
from
ba82678
to
2244eee
Compare
|
@zhangyanzhao Please add me as the reviewer. |
|
@Ashish1805 where do we stands with this HLD? |
please accept the invitation. |
|
This HLD was reviewed in SONiC community on 10/18/2022. |
|
Deferred from 202211 release. |
|
@Ashish1805 can you please help to add the code PRs as agreed in community? Also, please sign the EasyCLA, that is required before you can submit PRs. Thanks. |
|
HLD was reviewed in community on 10/18/2022. Keep a record |
This PR contains the HLD for link event damping. Co-authored-by: Mike Beresford <mberes@google.com> Signed-off-by: Ashish Singh <ashishksingh@google.com>
|
Hi @venkatmahalingam, Can you please take a look at the PR when get some time? Thank you. |
|
@eddyk-nvidia As based on the comments provided I have updated the PR, can you please take a look at the PR when you get some time? Thank you. |
|
Hi @lguohan, did we answer your question on why not using LUA script or do you have more question on that? Thank you. |
|
Hi @prgeor, Can you please take a look at the PR when get some time? Thank you. |
@Ashish1805 Ack. I should have my comments by 4/5 |
venkatmahalingam
approved these changes
Apr 10, 2023
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Nov 14, 2023
link event damping timer events. - Handler in the class will be used to handle the timer event of link event dampers. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Nov 16, 2023
link event damping timer events. - Handler in the class will be used to handle the timer event of link event dampers. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Nov 16, 2023
- Class to handle the port state change event callback from SAI and sending the events to syncd main thread for processing by link event damper. Depends on: sonic-net#1297 HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Nov 16, 2023
damping config attr. - Adding serialization/deserialization logic for link event damping config so that when libsai is sending link event damping algo and config to syncd for set request, it uses serialization logic to serialize the requested data before sending the set request and when syncd receives the link event damping port attribute set request, it uses the deserialization logic to deserialize the data. HLD: sonic-net/SONiC#1071
kcudnik
pushed a commit
to sonic-net/sonic-sairedis
that referenced
this pull request
Nov 16, 2023
…1312) Handler in the class will be used to handle the timer event of link event dampers. HLD: sonic-net/SONiC#1071
kcudnik
pushed a commit
to sonic-net/sonic-sairedis
that referenced
this pull request
Nov 16, 2023
- Class to handle the port state change event callback from SAI and sending the events to syncd main thread for processing by link event damper. Depends on: #1297 HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Nov 17, 2023
link event damper. - Link event damper running on each port will have its own SelectableTimer. This class helps create a mapping of SelectableTimer and object that created the SelectableTimer so that when timer is fired, proper EventHandler object can be invoked. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Nov 28, 2023
link event damper. - Link event damper running on each port will have its own SelectableTimer. This class helps create a mapping of SelectableTimer and object that created the SelectableTimer so that when timer is fired, proper EventHandler object can be invoked. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Nov 28, 2023
link event damper. - Link event damper running on each port will have its own SelectableTimer. This class helps create a mapping of SelectableTimer and object that created the SelectableTimer so that when timer is fired, proper EventHandler object can be invoked. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Nov 28, 2023
damping config attr. - Adding serialization/deserialization logic for link event damping config so that when libsai is sending link event damping algo and config to syncd for set request, it uses serialization logic to serialize the requested data before sending the set request and when syncd receives the link event damping port attribute set request, it uses the deserialization logic to deserialize the data. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Nov 29, 2023
damping config attr. - Adding serialization/deserialization logic for link event damping config so that when libsai is sending link event damping algo and config to syncd for set request, it uses serialization logic to serialize the requested data before sending the set request and when syncd receives the link event damping port attribute set request, it uses the deserialization logic to deserialize the data. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Nov 30, 2023
damping config attr. - Adding serialization/deserialization logic for link event damping config so that when libsai is sending link event damping algo and config to syncd for set request, it uses serialization logic to serialize the requested data before sending the set request and when syncd receives the link event damping port attribute set request, it uses the deserialization logic to deserialize the data. HLD: sonic-net/SONiC#1071
kcudnik
pushed a commit
to sonic-net/sonic-sairedis
that referenced
this pull request
Dec 4, 2023
…nt (#1322) damping config attr. - Adding serialization/deserialization logic for link event damping config so that when libsai is sending link event damping algo and config to syncd for set request, it uses serialization logic to serialize the requested data before sending the set request and when syncd receives the link event damping port attribute set request, it uses the deserialization logic to deserialize the data. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Dec 6, 2023
- This supports the link event damping config and algorithm set API. - Sends the link event damping config from libsai to syncd main thread. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Dec 12, 2023
- This supports the link event damping config and algorithm set API. - Sends the link event damping config from libsai to syncd main thread. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Dec 15, 2023
- Adding per port link event damper class that manages the internal behavior and workings of link event damping logic on a port where link event damping config is enabled. - This class keeps track of damping timer, current port state, post damping advertised port state and relevant debug counters per port. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Dec 15, 2023
- Adding per port link event damper class that manages the internal behavior and workings of link event damping logic on a port where link event damping config is enabled. - This class keeps track of damping timer, current port state, post damping advertised port state and relevant debug counters per port. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
Jan 12, 2024
- This supports the link event damping config and algorithm set API. - Sends the link event damping config from libsai to syncd main thread. HLD: sonic-net/SONiC#1071
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
May 10, 2024
- This supports the link event damping config and algorithm set API. - Sends the link event damping config from libsai to syncd main thread. HLD: sonic-net/SONiC#1071 Signed-off-by: Ashish Singh <ashishksingh@google.com>
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
May 10, 2024
- This supports the link event damping config and algorithm set API. - Sends the link event damping config from libsai to syncd main thread. HLD: sonic-net/SONiC#1071 Signed-off-by: Ashish Singh <ashishksingh@google.com>
|
@Ashish1805 , @royyi8, @mint570 , could you please add the following to complete the feature?
|
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
May 20, 2024
- This supports the link event damping config and algorithm set API. - Sends the link event damping config from libsai to syncd main thread. HLD: sonic-net/SONiC#1071 Signed-off-by: Ashish Singh <ashishksingh@google.com>
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
May 20, 2024
- This supports the link event damping config and algorithm set API. - Sends the link event damping config from libsai to syncd main thread. HLD: sonic-net/SONiC#1071 Signed-off-by: Ashish Singh <ashishksingh@google.com>
Ashish1805
pushed a commit
to Ashish1805/sonic-sairedis
that referenced
this pull request
May 28, 2024
- This supports the link event damping config and algorithm set API. - Sends the link event damping config from libsai to syncd main thread. HLD: sonic-net/SONiC#1071 Signed-off-by: Ashish Singh <ashishksingh@google.com>
@royyi8, gentle reminder. Can you please provide a plan for the above? We need sonic-mgmt tests to validate the feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the HLD for link event damping.
Following PRs are being added to support the syncd implemented link-event damping: