Persistent loglevel HLD #1041

EdenGri · 2022-07-31T10:39:49Z

This HLD document is describing the persistent loglevel feature.

Related PRs:

PR title	State	Context
[sonic-swss-common] Persistent loglevel
[sonic-utilities] Persistent loglevel
[sonic-buildimage] Persistent loglevel
Remove jinja2_cache
[sonic-buildimage] Remove LOGLEVEL DB
[sonic-snmpagent] Remove LOGLEVEL DB
[sonic-gnmi] Remove LOGLEVEL DB
[sonic-swss] Remove LOGLEVEL DB
[sonic-mgmt-common] Remove LOGLEVEL DB
[sonic-py-swsssdk] Remove LOGLEVEL DB

qiluo-msft · 2022-08-18T22:28:42Z

doc/logging/persistent_logger/persistent_loglevel.md

+  - In case of a warm upgrade, move Logger tables from LOGLEVEL DB to CONFIG DB (with a minor change in the key) and delete LOGLEVEL DB.
+  - Exposing the "del" function from the swss-common/sonicv2-connector.h to the db migrator. 
+
+(Downgrade will not be supported).


Downgrade will not be supported

@yxieca Can we skip downgrade in design? #Closed

Good catch. I don't think the feature has to work for downgrade. However, downgrade is an important operation. It is important to state what would be the behavior for downgrade.

Thanks @yxieca! I am mostly worried the process:

running with an image with this feature

downgrade to older image without this feature. By default, the new ConfigDB table is kept and no processes consume it

upgrade again to an image with this feature: since the config_db.json is carried over to new image, will it be override by "Logger tables from LOGLEVEL DB"?

In this case, after step 1: we will have the Logger tables in the CONFIG DB and the LOGLEVEL DB will be empty.
after step 2: the CONFIG DB will contain the old Logger tables and the LOGLEVEL DB will contain new Logger tables with default values.
after step 3: in case of warm-upgrade the content of the Logger tables from the CONFIG DB will be replaced by the content from the LOGLEVEL DB. and the LOGLEVEL DB will be empty.

That's nice design consideration. I am looking forward to have this in the design doc itself.

I just updated it, thanks!

* Add HLD for persistent logger

zhangyanzhao · 2022-11-11T19:51:12Z

@EdenGri are all code PRs captured in this HLD now? I see new code PRs came recently. Thanks.

EdenGri · 2022-11-13T12:11:07Z

@zhangyanzhao all code PRs captured in the HLD.

This PR is part of the following HLD: Persistent loglevel HLD: sonic-net/SONiC#1041 **- What I did** Deleted the LOGLEVEL_DB. After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use. **- How I did it** Removed the LOGLEVEL_DB from the SONiC code **- How to verify it** All tests were passed

This PR is part of the following HLD: Persistent loglevel HLD: sonic-net/SONiC#1041 - What I did Deleted the LOGLEVEL_DB. After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use. - How I did it Removed the LOGLEVEL_DB from the SONiC code - How to verify it All tests were passed

This PR is part of the following HLD: Persistent loglevel HLD: sonic-net/SONiC#1041 **- What I did** Deleted the LOGLEVEL_DB. After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use. **- How I did it** Removed the LOGLEVEL_DB from the SONiC code **- How to verify it** All tests were passed

This PR is part of the following HLD: Persistent loglevel HLD: sonic-net/SONiC#1041 - Why I did it After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use. - How I did it Removed the LOGLEVEL_DB from the SONiC code - How to verify it All tests were passed

This PR is part of the following HLD: Persistent loglevel HLD: sonic-net/SONiC#1041 **- What I did** Deleted the LOGLEVEL_DB. After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use. **- How I did it** Removed the LOGLEVEL_DB from the SONiC code **- How to verify it** All tests were passed

This PR is part of the following HLD: Persistent loglevel HLD: sonic-net/SONiC#1041 - Why I did it After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use. - How I did it Removed the LOGLEVEL_DB from the SONiC code - How to verify it All tests were passed

This PR is part of the following HLD: Persistent loglevel HLD: sonic-net/SONiC#1041 #### Why I did it After the Logger tables moved from the LOGLEVEL_DB to the CONFIG_DB and the jinja2_cache was deleted the LOGLEVEL_DB is not in use. #### How I did it Removed the LOGLEVEL_DB from the SONiC code #### How to verify it All tests were passed

EdenGri added 30 commits June 20, 2022 19:58

Add HLD for persistent logger

52c2e19

update

6f4d1d2

Update

f6173a3

Update

954f843

Update

5646822

Update

071fafc

Update

d0b20ca

Update

3ecc19b

Update

5caa7ec

Update

db7b45a

Update

eb307aa

Update

fc18b1b

Update

035fa77

update after Drors comments

12f07c6

update after Drors comments

e1e5ba4

update after Drors comments

9a7b76d

update after Drors comments

e541d01

update

c62b1fc

update

eea57b5

update

027a02c

update

c4239c9

update

23bac8c

update

3770ec0

update

ab923fd

update

f45932a

update

51d11fe

change approach to the config db approach

b9fe380

update

3451f4e

update not removing LOGLEVEL DB

f3f30c5

update

9a6cb12

qiluo-msft requested a review from yxieca August 18, 2022 22:28

qiluo-msft reviewed Aug 18, 2022

View reviewed changes

add description of not supporting downgrade

0279cad

EdenGri dismissed dprital’s stale review via 0279cad August 26, 2022 15:40

update TOC

b57aea1

qiluo-msft previously approved these changes Aug 26, 2022

View reviewed changes

add section of support downgrade

911c574

EdenGri dismissed qiluo-msft’s stale review via 911c574 August 30, 2022 14:34

yxieca approved these changes Aug 30, 2022

View reviewed changes

Merge branch 'master' into persistent_loglevel

fd646cc

yxieca merged commit 67e7e73 into sonic-net:master Aug 30, 2022

dprital mentioned this pull request Sep 7, 2022

Remove jinja2_cache sonic-net/sonic-buildimage#11996

Merged

7 tasks

itamar-talmon pushed a commit to itamar-talmon/SONiC that referenced this pull request Oct 2, 2022

Persistent loglevel HLD (sonic-net#1041)

e13ac5a

* Add HLD for persistent logger

zhangyanzhao added the request 202211 label Nov 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Persistent loglevel HLD #1041

Persistent loglevel HLD #1041

EdenGri commented Jul 31, 2022 •

edited

Loading

qiluo-msft Aug 18, 2022 •

edited

Loading

yxieca Aug 21, 2022 •

edited

Loading

qiluo-msft Aug 21, 2022

EdenGri Aug 22, 2022 •

edited

Loading

qiluo-msft Aug 25, 2022

EdenGri Aug 26, 2022

zhangyanzhao commented Nov 11, 2022

EdenGri commented Nov 13, 2022

Persistent loglevel HLD #1041

Persistent loglevel HLD #1041

Conversation

EdenGri commented Jul 31, 2022 • edited Loading

qiluo-msft Aug 18, 2022 • edited Loading

Choose a reason for hiding this comment

yxieca Aug 21, 2022 • edited Loading

Choose a reason for hiding this comment

qiluo-msft Aug 21, 2022

Choose a reason for hiding this comment

EdenGri Aug 22, 2022 • edited Loading

Choose a reason for hiding this comment

qiluo-msft Aug 25, 2022

Choose a reason for hiding this comment

EdenGri Aug 26, 2022

Choose a reason for hiding this comment

zhangyanzhao commented Nov 11, 2022

EdenGri commented Nov 13, 2022

EdenGri commented Jul 31, 2022 •

edited

Loading

qiluo-msft Aug 18, 2022 •

edited

Loading

yxieca Aug 21, 2022 •

edited

Loading

EdenGri Aug 22, 2022 •

edited

Loading