Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License of base64id #403

Closed
edi9999 opened this issue Jun 21, 2016 · 2 comments
Closed

License of base64id #403

edi9999 opened this issue Jun 21, 2016 · 2 comments

Comments

@edi9999
Copy link
Contributor

edi9999 commented Jun 21, 2016

Hi,

the released version of the package base64id is "none", which can have some legal issues (code without license is considered as copyleft, eg you have no rights on it). The package maintainer doesn't seem to want/have time for updating the published package. (faeldt/base64id#6)

Since they is a LICENSE in the git repository, we could simply copy the only file of this package inside engine.io

This also has the benefit of being less dependent on other packages (events with kik , left-pad).

Would you accept a pull request that would take the one file of the base64id into the source code of engine.io ?

@kapouer
Copy link
Contributor

kapouer commented Jun 21, 2016

The problem doesn't come from the package.json file itself: a missing license there has no legal implication. However, the published base64id npm package doesn't contain its LICENSE file - this is indeed an issue.

@darrachequesne
Copy link
Member

Closed by #451.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants