"cargo update" brings in a protobuf version (2.9.0) that doesn't compile.

[hrydgard]

Try to just run cargo update in the root directory, then cargo build.

Some cargo.toml dependency needs to be tightened down, or things need to be fixed to work with the new version of protobuf.

I first thought the culprit was harness/onnx-test-suite/debug-utils/Cargo.toml where it's set to "*", but no dice changing that.

[kali]

yeah, i'm on it:)

[kali]

The CI broke last night, actually, so I was aware. Thanks for the heads-up.

[hrydgard]

Cool, haven't watched your CI :)

Seems that rust-protobuf accidentally pushed a busted version:
stepancheg/rust-protobuf@721e3ff

[hrydgard]

Might want to consider checking in Cargo.lock by the way. The diffs aren't the prettiest, but it firmly blocks this sort of third-party breakage.

[kali]

It's a bit more subtle, the problem is I actually committed the protobuf generated files. I did that a long time ago when the protobuf generator required a working protoc on the platform, and that was raising all kind of issues on build/CI machines. And right now we have a 2.18 (or lower, haven't checked) generated files that are incompatible with the new 2.19 generator... So if you're using the protobuf suite "correctly", the version is not a bust.

Now that we have a more build.rs self-contained generated, I will maybe move back the generation in build.rs. I plan to try that this afternoon.

As for commiting Cargo.lock, it may help for the command line tool, but it is ignored for libraries, so it's only a partial fix.

[hrydgard]

In that case though I should be able to get back to a locally working state by modifying your protobuf = dependencies to an older version.

But I only find

harness/onnx-test-suite/Cargo.toml:protobuf = "2.4.2"
harness/onnx-test-suite/debug-utils/Cargo.toml:protobuf = "*"
onnx/Cargo.toml:protobuf = "2.0"
tensorflow/Cargo.toml:protobuf = "2.0"

None of them are set to just 2, which would result in the automatic upgrade from 2.18 to 2.19 you are describing. Or do you mean 2.0.18 and 2.0.19 ? I tried forcing them to 2.0.18 which didn't work.

[kali]

Ho, sorry, did not realise you were actually stuck. I have pushed a "bump" branch here with a temporary fix (re-generating the files by hand). #175

It should unstuck you, while I'm doing the right thing, and getting those generated files out of git.

I think you may have been able to workaround by doing some targetted cargo updates (cargo update -p protobuf --precise 2.0.18 or something like that to revert the version bump, but now I guess you'd better try the bump branch.

[hrydgard]

Cool, thanks! Bump branch seems fine.

[kali]

0.5.3 should fix it ! Thanks for your patience :)

[kali]

except... now that new version of protobuf has been yanked.

Will fix and release again

[kali]

So, 0.5.4 should do the trick... wow, what a week.

[hrydgard]

Great! And the week has only just started :)

[kali]

Hey @hrydgard, are we ok to close this one ?

[hrydgard]

Yeah, sorry, it's all good now.