Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default request timeouts #256

Closed
5 tasks done
Tracked by #724 ...
rcoh opened this issue Mar 17, 2021 · 3 comments
Closed
5 tasks done
Tracked by #724 ...

Default request timeouts #256

rcoh opened this issue Mar 17, 2021 · 3 comments
Assignees
Milestone

Comments

@rcoh
Copy link
Collaborator

rcoh commented Mar 17, 2021

  • Rename API timeouts to operation timeouts and move them into TimeoutConfig
  • Remove currently unused TCP/HTTP timeout config structs
  • Add connect_timeout to TimeoutConfig and default it to 3100 milliseconds
  • Implement support for connect timeout
  • Integration test all supported timeouts
@rcoh rcoh mentioned this issue Sep 27, 2021
6 tasks
@rcoh rcoh added this to the GA milestone Dec 13, 2021
@jdisanti jdisanti mentioned this issue Aug 31, 2022
28 tasks
@jdisanti
Copy link
Collaborator

Breaking out the per-operation override capability out into #1732 since that requires a good bit of design work and refactoring.

@jdisanti
Copy link
Collaborator

Defaults should be the following for now:

connectTimeoutInMillis: 3100
tlsNegotiationTimeoutInMillis: 3100

Taken from the current sdk-default-configuration.json standard mode: https://github.com/awslabs/aws-sdk-rust/blob/a58ba1a21f383b26e09ebdd4cc07d57a87e30388/aws-models/sdk-default-configuration.json#L12-L16

@jdisanti jdisanti self-assigned this Sep 13, 2022
@jdisanti jdisanti changed the title Request timeouts Default request timeouts Sep 13, 2022
@jdisanti
Copy link
Collaborator

jdisanti commented Sep 13, 2022

It looks like only the API timeouts have been implemented, so these defaults can't be set yet. Will need to implement the TCP and HTTP timeouts.

Edit: From discussion with @Velfi, these timeouts don't need to get implemented. I will pare down the configuration interface to remove them for now, and will update this issue description with remaining work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants