Remove Protocol enum #1829
Remove Protocol enum #1829
Conversation
hlbarber
added
server
hlbarber
force-pushed
the
harryb/remove-error-kind
branch
from
0469b3b
to
236d6ea
Compare
| { | ||
| Self { | ||
| handlers, | ||
| into_response: PyMiddlewareException::into_response, |
There was a problem hiding this comment.
We store the into_response here as a fn to immediately erase the P type. This prevents any further generics in the parent structs.
| "aws.protocols#awsjson10" => Protocol::AwsJson10, | ||
| "aws.protocols#awsjson11" => Protocol::AwsJson11, | ||
| _ => { | ||
| return Err(PyException::new_err(format!( |
There was a problem hiding this comment.
This fallibility is gone. It's replaced by the bound PyMiddlewareException: IntoResponse<P> on the Layer::layer below. We can move it up to the constructor if we want the compile error more eagerly.
|
|
||
| /// Tower [Layer] implementation of Python middleware handling. | ||
| /// | ||
| /// Middleware stored in the `handlers` attribute will be executed, in order, | ||
| /// inside an async Tower middleware. | ||
| #[derive(Debug, Clone)] | ||
| pub struct PyMiddlewareLayer { | ||
| pub struct PyMiddlewareLayer<P> { |
There was a problem hiding this comment.
TODO: Add documentation on what this P is. What is it, where do you find it etc?
| @@ -63,8 +63,6 @@ pub trait PyApp: Clone + pyo3::IntoPy<PyObject> { | |||
|
|
|||
| fn middlewares(&mut self) -> &mut PyMiddlewares; | |||
|
|
|||
| fn protocol(&self) -> &'static str; | |||
There was a problem hiding this comment.
I've removed this because there's currently no method to go from struct AwsRestJson1 (etc) to "aws.protocols#restJson1". This can be easily added though if desired.
There was a problem hiding this comment.
Or we can simply write a code generated literal in the implementation.
There was a problem hiding this comment.
This protocol method in this trait was a hack to be honest. I like what you did here.
...are/amazon/smithy/rust/codegen/server/python/smithy/generators/PythonApplicationGenerator.kt
Show resolved
Hide resolved
hlbarber
force-pushed
the
harryb/remove-error-kind
branch
from
693c15e
to
fd100dd
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Fix missing import Fix missing markerStruct
hlbarber
force-pushed
the
harryb/remove-error-kind
branch
from
12f9149
to
2c8f536
Compare
hlbarber
force-pushed
the
harryb/remove-error-kind
branch
from
fc3b3a3
to
4f7fc07
Compare
Fix python tests Restore default Add missing codegenScope Fix missing new::<P>
hlbarber
force-pushed
the
harryb/remove-error-kind
branch
from
4f7fc07
to
043c06f
Compare
|
There are still some failure in CI, but they are trivial misses. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Motivation and Context
The
Protocolenum defines a closed set of protocols supported by therust-runtimecrates. Its use within interfaces restricts extensibility.While this is not a solution to #1703 it does progress towards the general goal.
Description
Protocolenum fromaws-smithy-http-server.Protocolacrossaws-smithy-http-server.IntoResponse<P>on theRuntimeError.RuntimeErrorand renameRuntimeErrorKindtoRuntimeError.Protocolacrossaws-smithy-http-server-python.PwithPyMiddlewareException: IntoResponse<P>. It is no longer fallible.PyApp::protocolmethod.Notes
The most contentious changes occur within the
aws-smithy-http-server-pythonchanges.