Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to set HTTP Connectors in Configs #1225

Closed
Velfi opened this issue Feb 25, 2022 · 4 comments
Closed

Allow users to set HTTP Connectors in Configs #1225

Velfi opened this issue Feb 25, 2022 · 4 comments
Assignees
Labels
breaking-change This will require a breaking change sdk sdk-ga
Milestone

Comments

@Velfi
Copy link
Contributor

Velfi commented Feb 25, 2022

Refactor our current network stack to allow users to set HTTP Connectors in Service Configs and Shared Configs.

Then, update Service Client creation to use this connector instead of creating a connector from defaults based on the currently enabled features.

This is in support of the "How we should use features" RFC.

@Velfi Velfi self-assigned this Feb 25, 2022
@jdisanti
Copy link
Collaborator

The connector customization needs to play into network calling credential providers (e.g., IMDS, HTTP token, etc) provider initialization as well: awslabs/aws-sdk-rust#579

@jdisanti jdisanti added this to the SDK GA milestone Sep 30, 2022
@jdisanti jdisanti added breaking-change This will require a breaking change sdk labels Sep 30, 2022
@jdisanti
Copy link
Collaborator

This would probably be implemented along side #960

@Velfi
Copy link
Contributor Author

Velfi commented Oct 28, 2022

This is partly implemented by #1918

@jdisanti
Copy link
Collaborator

This was included in release-2022-12-14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This will require a breaking change sdk sdk-ga
Projects
None yet
Development

No branches or pull requests

2 participants