'ZmqREPConnection' object has no attribute '_routingInfo'

[aryes]

In our project we encountered the following failure:

  File "/opt/neo/venv/lib/python2.7/site-packages/txzmq/req_rep.py", line 153, in __init__
    ZmqConnection.__init__(self, *args, **kwargs)
  File "/opt/neo/venv/lib/python2.7/site-packages/txzmq/connection.py", line 174, in __init__
    self.doRead()
  File "/opt/neo/venv/lib/python2.7/site-packages/txzmq/connection.py", line 281, in doRead
    log.callWithLogger(self, self.messageReceived, message)
--- <exception caught here> ---
  File "/opt/neo/venv/lib/python2.7/site-packages/twisted/python/log.py", line 88, in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/opt/neo/venv/lib/python2.7/site-packages/twisted/python/log.py", line 73, in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/opt/neo/venv/lib/python2.7/site-packages/twisted/python/context.py", line 118, in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/opt/neo/venv/lib/python2.7/site-packages/twisted/python/context.py", line 81, in callWithContext
    return func(*args,**kw)
  File "/opt/neo/venv/lib/python2.7/site-packages/txzmq/req_rep.py", line 179, in messageReceived
    self._routingInfo[msgId] = routingInfo
exceptions.AttributeError: 'ZmqREPConnection' object has no attribute '_routingInfo'

It seems like the doRead called during initialization of ZmqREPConnection actually gets a message and tries to handle it, before the _routingInfo attribute was initialized later in its __init__.

[smira]

nice catch, it should be easy to fix by reorderding lines in __init__

[aryes]

Thanks for the quick reply. I looked at the commit and it looks like something is missing. I expected to see a change in req_rep.py, class ZmqREPConnection, lines 153-154:

        ZmqConnection.__init__(self, *args, **kwargs)
        self._routingInfo = {}  # keep track of routing info

the order of these lines should change, doesn't it?

Also, when will this change be available as a formal release?
Thanks :-)

[smira]

oh, looks like I somehow missed the 2nd constructor, sorry for that. I'll get it fixed and do a next release

[smira]

0.8.2 should be good I hope

[aryes]

Thanks you very much for the quick fix! :-) On Thursday, November 14, 2019, 04:38:06 PM GMT+2, Andrey Smirnov <notifications@github.com> wrote: 0.8.2 should be good I hope — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.