Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with the brig CLI #56

Open
radu-matei opened this issue Jan 28, 2019 · 2 comments
Open

Integration with the brig CLI #56

radu-matei opened this issue Jan 28, 2019 · 2 comments

Comments

@radu-matei
Copy link

radu-matei commented Jan 28, 2019

Let me start by saying this is a tool that I use daily with Brigade, and it has made my life much easier - thanks!

And because lots of people use this together with the brig CLI, it means it is required for them to install two separate tools - not an ideal user experience, in my opinion - would it make sense to have an integration between brig and brigadeterm - something along the lines of brig term?

Ideally, we would vendor this package and replicate the functionality of Brigadeterm.

What do you think?
Also, are there any obvious blockers to doing this?

Thanks!

cc @technosophos

@slok
Copy link
Owner

slok commented Jan 28, 2019

Hi @radu-matei!

I understand what you say and yes, it makes a lot of sense to only have one tool.

I'm open to any suggestion, this is, vendoring as you say, or moving this to a more official Brigade repository or having inside Brigade. I don't mind moving the Github Repo either, whatever it makes more sense forBrigade end users and maintainers.

Talking about the code, I don't see any blockers, I use Brigade go Store API and everything is Go. After talking and deciding how we could integrate I can make some changes to make it more "integrable" if is required, although at first, I don't see anything that could block it.

@slok slok pinned this issue Jan 28, 2019
@radu-matei
Copy link
Author

That is great!
I'll open an issue in the Brigade repo to track this.

As to migrating to a more official org, we started migrating various things to https://github.com/brigadecore, with the intention to move everything there, and we
re currently making sure we have everything setup there CI, CLA bot, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants