mailcatcher: fix missing assets #174319
Closed
mailcatcher: fix missing assets #174319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this step the user interface does not function because the javascript and stylesheets are not compiled or included, so cannot be served to browsers. See sj26/mailcatcher#560
github-actions
bot
added
nodejs
|
This isn't going to work as-is because the compile-dependencies aren't installed. It looks like swiftgen installs bundler for use at build time: homebrew-core/Formula/s/swiftgen.rb Lines 24 to 38 in 9643970 Maybe this should do the same. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This seems to have been closed due to lack of activity, but ... it's still an issue. How do we re-open it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this step the user interface does not function because the javascript and stylesheets are not compiled or included, so cannot be served to browsers.
This command was run in the formula for v0.9.0 but was removed in the update to v0.10.0 (#173471):
104b175#diff-aff4c5be3f339d85e769e3c2362bb626acfde080d57d0bb75f42551ecc3d0413L161
Closes sj26/mailcatcher#560.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?