Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StaticCPD is confusing #40

Open
tawheeler opened this issue Dec 9, 2016 · 3 comments
Open

StaticCPD is confusing #40

tawheeler opened this issue Dec 9, 2016 · 3 comments
Assignees

Comments

@tawheeler
Copy link
Contributor

It seems like StaticCPD is confusing users.

A StaticCPD is just a CPD which always returns the same distribution, no matter what the parent values are. I did not want to call it ParentlessCPD because it can technically have parents, they just don't do anything.

Some possible ways to rename it are IndependentCPD or ParentAgnosticCPD. Neither of these sound great.

Does anyone have a better name?

@mykelk
Copy link
Member

mykelk commented Dec 9, 2016

I was confused by this, but I'm having trouble thinking of a better name. Maybe just more documentation?

@hpoit
Copy link
Contributor

hpoit commented Mar 20, 2017

Is a StaticCPD just a cumulative distribution function that takes in more than one real-valued random variable X, or a distribution function of more than one X? I don't understand why there should be a function just for this case, instead of making just one general CDF that allows the user to include whatever X it wants, type child, type parent, or both.

On a separate note, thanks for all the help you've been giving me.

@jpfairbanks
Copy link
Contributor

It makes sense to think of this a ConstantCPD because a constant functions is an f(x) = k and here we have a CPD p(Y|X) = p(Y). I know it has been over 3 years since this issue was opened so this might be moot at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants