Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved detection on Linux. #36

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
node_modules
yarn.lock
*.log
4 changes: 2 additions & 2 deletions lib/linux.js
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ function setAvailableApps() {
});

// `which` all commands and expect stdout to return a positive
const whichCmd = `which -a ${names.join('; which -a ')}`;
const whichCmd = `which -a ${names.join(' ')}`;

return cp.exec(`echo $(${whichCmd})`).then(stdout => {
stdout = stdout.trim();
Expand All @@ -133,7 +133,7 @@ function setAvailableApps() {

// It may return aliases so we only want the real path
// and only the executable name. i.e. 'foo' from /bin/foo
stdout = stdout.split('\n');
stdout = stdout.split(' ');

stdout.forEach(el => {
// It's an alias
Expand Down