Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of committed datatype metadata with h5wasm #1708

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Conversation

axelboc
Copy link
Contributor

@axelboc axelboc commented Sep 9, 2024

I was wrongly calling get_dataset_metadata instead of get_datatype_metadata on committed datatypes.

But get_datatype_metadata (and later get_attribute_names) had issues of their own, which are now fixed in https://github.com/usnistgov/h5wasm/releases/tag/v0.7.7 and https://github.com/usnistgov/h5wasm/releases/tag/v0.7.8

I'm also making use of the new Module#open and Module#close_file methods to avoid using the low-level ccall method, and I refactor the h5wasm demo to allow dropping a new file on top of the viewer (like in myHDF5) so I can make sure that the clean-up effects of the providers do call close_file as expected.

Peek 2024-09-09 14-05

@axelboc axelboc merged commit bb2b128 into main Sep 9, 2024
8 checks passed
@axelboc axelboc deleted the up-h5wasm branch September 9, 2024 13:34
@axelboc axelboc mentioned this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants