Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitsign bot #27

Open
lukehinds opened this issue May 14, 2022 · 3 comments
Open

gitsign bot #27

lukehinds opened this issue May 14, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@lukehinds
Copy link
Member

lukehinds commented May 14, 2022

Throw DCO bot in the toilet and take over things with gitsign bot.

In all seriousness, a bot that checks commits are signed, or fails CI.

@lukehinds lukehinds added the enhancement New feature or request label May 14, 2022
@dlorenc
Copy link
Member

dlorenc commented May 14, 2022

This is definitely doable but a bit tricky, there are a few options. A github action can do some of these checks, but must be manually configured by each repo admin. We can put it in the template, but then each repo owner needs to keep it there and keep it up to date. There's no centralized way to manage them.

A github app can be installed and configured by an org admin, and it also gets more access to the Github api than the actions do. This is why the DCO bot is an application rather than an action.

@haydentherapper
Copy link
Contributor

Is it possible to make identity visible when inspecting the signature in the UI? I’ve seen only the common name and organization, which makes it hard to quickly verify the signer when reviewing commits.

@caniszczyk
Copy link

FYI github will be adding DCO support in the github UI soon btw todogroup/gh-issues#50 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants