-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompositeValidator valid percentaje #481
Comments
Hi Jonathan, |
Yes it would, it'd a lot easier than saving an List |
Short update: @gbalderas is working on this. |
Thanks a lot guys |
Hello, while doing the test, I noticed that if the same error message is used by different Validators, all of them will be removed from the HashMap of messages in the CompositeValidationStatus (line 136). When this happens my test fails since my Binding cannot be updated because it is bound to the messages ObservableList. Also the list of messages in the CompositeValidator will be reduced to 1, making it impossible to know how many validators are valid based on the message count. But if I do a for loop for each element in the validators list, I can count how many of them are valid. Is this intentional? Should every validator message be removed if there are used more than once? Or should every Validator have a different/unique message? If it is intentional, maybe the CompositeValidator can give a number or an observable value of how many validators are valid? |
Hi @gbalderas, However, I don't think this is connected to the actual issue we are trying to solve here. Can you please create a new issue for this particular problem and create the PullRequest for this issue here anyway? |
@pichardoJ can you please take a look at PR #486. Does this solve your use case? |
@lestard yes it does, thank you and @gbalderas for the quick response |
Hi, guys
I've come with the need of displaying the percentage of completion of a form and we decided to display the percentage of valid inputs in the form, so I looked on
CompositeValidator
to see if there was a way to get the validators or at least the number of validators in the composite and there is not.Although I know this is just a really really really backlog feature, it would be nice to have it.
Thanks guys
The text was updated successfully, but these errors were encountered: