Feature/expose headers and send #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Idea looks pretty nice. But I need time to investigate 'cause changes are major |
|
No worries. Take your time to review and I'm happy to answer any questions or make modifications to my PR. |
|
Ok, LGTM :D @kilahm can you merge conflicts? I'm going to accept PR) |
This is accomplished by creating a mock request parallel to the current route being processed. The mock request stores values passed by set() and send() which are then passed to the function returned by Route.match().
kilahm
force-pushed
the
feature/expose_headers_and_send
branch
from
1caf25f
to
90cbb0d
Compare
|
@shuvalov-anton Should be good to go now! :) |
|
@shuvalov-anton you still interested in this? It'd be cool to point my project back to your repo rather than my fork. |
|
Yay! Sorry for delay. I've had a bunch of work :D |
|
@kilahm yay! I gonna give you commit rights :D |
|
@kilahm published with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is accomplished by creating a mock request parallel to the current
route being processed. The mock request stores values passed by set()
and send() which are then passed to the function returned by
Route.match().
I would like this functionality because I would like to make sure my wrapper for
superagentis setting the correct custom headers and filling in default values for the JSON body.This PR also renames
Route.fntoRoute.handlerand thecallbackscollection toroutes. I believe these names more closely align with their purpose in this library. I'm happy to remove the name changes if you don't like them.