Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no UI to toggle cardset bottoms #347

Open
denilsonsa opened this issue Oct 18, 2023 · 1 comment
Open

There is no UI to toggle cardset bottoms #347

denilsonsa opened this issue Oct 18, 2023 · 1 comment

Comments

@denilsonsa
Copy link

4c2dd59 added a new option use_cardset_bottoms, which toggles between using auto-generated card bottoms, or using the cardset-provided bottoms. That option exists in the config file and it works.

However, so far there is no UI to toggle that option. I expected to have a menu toggle under Options → Card view.


Well, it works but it can be improved. If the cardset bottom is not found, PySol should probably print a warning message to the terminal (so people would be aware of the issue), and should probably fall back to generating one programmatically (or to using the (non-)negative version).

@joeraz
Copy link
Collaborator

joeraz commented Oct 20, 2023

Agreed. I'd like to add such an option. The main issue is that the generated bottoms are loaded separately from the cardset-specific bottoms. So if I add such an option, it would only work for cardsets loaded after the change. Would need to alter cardset loading logic to account for this, so it's a little more difficult to do than it sounds.

I've already added the missing bottoms files to the cardsets repo for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants