-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrupted composer is installed using v1 #239
Comments
This comment has been minimized.
This comment has been minimized.
@shivammathur Can't there be some exit code check added to break this GHA step if the setup couldn't finish properly? |
@mfn Added, will be there in next release. |
Wow, I saw the commit 82a0dd8 . So much work what I thought would be just an Much appreciated 🙇 |
Also improved how different versions of composer are setup, so most of 82a0dd8 is that. |
Awesome, will try it out! 😼 |
Describe the bug
Things where working fine yesterday in the afternoon. But workflows running yesterday evening (19:35 UTC+2) installed a corrupted version of composer (without the setup-php step reporting a failure, so the failure was only reported by a later step using composer)
Version
v1
orv2
.v2
v1
I haven't checked v2
Runners
Operating systems
linux
PHP versions
7.3
To Reproduce
Expected behavior
A usable version of composer is installed.
And another expectation would be that such fatal error actually makes the setup report a failure rather than failing silently.
Screenshots/Logs
Here is the output of the setup-php step:
Additional context
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: