From 2e63ca9f645b29cdfe06c18671ced368edcf223c Mon Sep 17 00:00:00 2001 From: Nicholas Blumhardt Date: Sun, 23 Jun 2019 12:45:30 +1000 Subject: [PATCH] Fix flipped conditional introduced in earlier provider support PR --- .../SerilogWebHostBuilderExtensions.cs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Serilog.AspNetCore/SerilogWebHostBuilderExtensions.cs b/src/Serilog.AspNetCore/SerilogWebHostBuilderExtensions.cs index 8a2e673..6d22578 100644 --- a/src/Serilog.AspNetCore/SerilogWebHostBuilderExtensions.cs +++ b/src/Serilog.AspNetCore/SerilogWebHostBuilderExtensions.cs @@ -88,6 +88,7 @@ public static IWebHostBuilder UseSerilog( { if (builder == null) throw new ArgumentNullException(nameof(builder)); if (configureLogger == null) throw new ArgumentNullException(nameof(configureLogger)); + builder.ConfigureServices((context, collection) => { var loggerConfiguration = new LoggerConfiguration(); @@ -105,13 +106,13 @@ public static IWebHostBuilder UseSerilog( ILogger registeredLogger = null; if (preserveStaticLogger) { - // Passing a `null` logger to `SerilogLoggerFactory` results in disposal via - // `Log.CloseAndFlush()`, which additionally replaces the static logger with a no-op. - Log.Logger = logger; + registeredLogger = logger; } else { - registeredLogger = logger; + // Passing a `null` logger to `SerilogLoggerFactory` results in disposal via + // `Log.CloseAndFlush()`, which additionally replaces the static logger with a no-op. + Log.Logger = logger; } collection.AddSingleton(services =>