Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go Mail Helper Refactor #152

Open
thinkingserious opened this issue Oct 10, 2017 · 9 comments
Open

Go Mail Helper Refactor #152

thinkingserious opened this issue Oct 10, 2017 · 9 comments
Assignees
Labels
difficulty: very hard fix is very hard in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 10, 2017

Issue Summary

An interface to easily interact with the mail/send endpoint of the SendGrid v3 Web API.

The specification for this project is here.

Acceptance Criteria

All of the use cases defined here are implemented and all corresponding tests are passing.

@thinkingserious thinkingserious added difficulty: very hard fix is very hard in difficulty hacktoberfest status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap labels Oct 10, 2017
@suchitparikh
Copy link
Contributor

I got it

@thinkingserious
Copy link
Contributor Author

@dtjm @extemporalgenome @Dharmik-Patel @deckarep @0sc @berto

If you are tagged on this message, it means we are particularly interested in your feedback :)

If you don't have the time, no worries and my apologies for the disturbance.

If you do have the time, please take a look at the proposed helper upgrade above and let us know what you think. Any and all feedback is greatly appreciated.

Thanks in advance!

@dtjm
Copy link
Contributor

dtjm commented Nov 28, 2017

@thinkingserious which link did you want us to review?

@thinkingserious
Copy link
Contributor Author

Hi @dtjm!

The relevant links are in the Issue Summary above.

Specifically, this link is the proposed specification and this link is the discussion around that proposal. And the goal is to implement these use cases.

Thanks!

With Best Regards,

Elmer

@hothero
Copy link

hothero commented Jan 5, 2018

Hi, I have two suggestions:

  1. we need to define interface and generate mock for user easily to test once they are integrating this package, can reference this issue: Make testing easier with interfaces #36

  2. we need a kind of NewBatchEmail function to support send multiple recipients in the same time, more can reference here: should we have NewBatchEmail function to support multiple recipients?  #247

thanks for your reading, I can help contributing if those suggestions are accepted and you need

@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing type: getting started question while getting started and removed status: help wanted requesting help from the community labels Mar 6, 2018
@hothero
Copy link

hothero commented May 7, 2018

@thinkingserious I found above message is changed to work in progress, where we can follow the related progress and make contribution?

@thinkingserious
Copy link
Contributor Author

@suchitparikh ^^

@titouanfreville
Copy link

Hello here. Is this issue still in progress ?

Having this interface would really be nice. Also, providing a default mock using testify could be a simple way to allow lot of people to use it.

Having to make a wrapper for unit testing is quite annoying 👍 :)

Thanks for your work 👍

@childish-sambino
Copy link
Contributor

@titouanfreville Nope, looks like there is no one currently working on this issue.

@childish-sambino childish-sambino added status: help wanted requesting help from the community and removed status: work in progress Twilio or the community is in the process of implementing type: getting started question while getting started labels Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: very hard fix is very hard in difficulty status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

6 participants