This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
fix(decorateClientConfig): Make config object optional #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct autoprefixerConfig param
markdalgleish
changed the title
|
Just changed the title so that it's more user-facing. Make sure you update the commit message when merging :) |
| @@ -212,7 +212,7 @@ const decorateServerConfig = (config, options) => { | |||
| }); | |||
| } | |||
|
|
|||
| const postcssPlugins = ({ cssSelectorPrefix }, autoprefixerConfig) => | |||
There was a problem hiding this comment.
Strange, I would have thought the linter would have picked this up, since we're shadowing an existing variable 🤔
There was a problem hiding this comment.
Might be worth double checking the lint rules.
markdalgleish
approved these changes
Oct 26, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.