Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple printing of unexpected output from progress printer #5445

Closed
sebastianbergmann opened this issue Jul 14, 2023 · 1 comment
Closed

Decouple printing of unexpected output from progress printer #5445

sebastianbergmann opened this issue Jul 14, 2023 · 1 comment
Assignees
@sebastianbergmann
Labels
feature/test-runner CLI test runner

Comments

@sebastianbergmann
Copy link
Owner

sebastianbergmann commented Jul 14, 2023 •
edited
Loading

PHPUnit uses PHP's output buffering to capture output made by test(ed) code. When the test does not perform assertions on captured output then the output is considered unexpected and an PrintedUnexpectedOutput event is emitted. The ProgressPrinter (which is controlled by the --no-progress CLI option) is currently not only responsible for printing progress (., E, F, ...) but also for printing unexpected output.

Originally posted by @sebastianbergmann in #5367 (comment)
@sebastianbergmann sebastianbergmann self-assigned this Jul 14, 2023
@sebastianbergmann sebastianbergmann added feature/test-runner CLI test runner type/enhancement A new idea that should be implemented labels Jul 14, 2023
@sebastianbergmann sebastianbergmann added this to the PHPUnit 10.3 milestone Jul 14, 2023
@sebastianbergmann sebastianbergmann removed the type/enhancement A new idea that should be implemented label Jul 14, 2023
@sebastianbergmann sebastianbergmann removed this from the PHPUnit 10.3 milestone Jul 14, 2023
@sebastianbergmann sebastianbergmann mentioned this issue Jul 14, 2023
Closed
@SakiTakamachi
Copy link

@sebastianbergmann
Thank you for your very quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
feature/test-runner CLI test runner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebastianbergmann @SakiTakamachi