Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad instrument view button formatting #313

Closed
jl-wynen opened this issue Jan 25, 2024 · 2 comments · Fixed by #314
Closed

Bad instrument view button formatting #313

jl-wynen opened this issue Jan 25, 2024 · 2 comments · Fixed by #314

Comments

@jl-wynen
Copy link
Member

In the rendered docs, the 'toggle outline visibility' button of instrument views has a bad icon:
Screenshot_20240125_111730
It alternates between an exclamation mark and question mark.

@nvaytet
Copy link
Member

nvaytet commented Jan 26, 2024

I've also noticed this. This is a new thing, it used to work.
I don't know if it's some css issue (maybe something similiar to what is discussed here?) or something else.

Note that the other icons are ok (home and camera). The icon for the outline is the codepen icon. It's from the brands section. Maybe something is up with the brands-specific icons?

@nvaytet
Copy link
Member

nvaytet commented Jan 26, 2024

If the brand icons are the issue, we could consider changing things round a little:

  • Use the cube icon for the outline toggle
  • Use the layer-group icon for the spatial cutting tool
  • And it would also be nice to harmonise the look/feel by having an icon for the RGB axes instead of a unicode character. Would something like a ruler do? Or maybe this dice although probably too similar to the cube?

Or:

@nvaytet nvaytet transferred this issue from scipp/scippneutron Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants