Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --no-use-pip-constraints option #60

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

sbidoul
Copy link
Owner

@sbidoul sbidoul commented Jul 8, 2021

Users should switch to a pip version that supports URL as constraints (it was only unsupported in pip 20.3 and 21.0 with the new resolver).

@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #60 (217d3cb) into master (00ce790) will increase coverage by 3.55%.
The diff coverage is 94.72%.

❗ Current head 217d3cb differs from pull request most recent head fc8c027. Consider uploading reports for the commit fc8c027 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   92.04%   95.60%   +3.55%     
==========================================
  Files          11       16       +5     
  Lines         465      932     +467     
  Branches       86      173      +87     
==========================================
+ Hits          428      891     +463     
  Misses         27       27              
- Partials       10       14       +4     
Impacted Files Coverage Δ
src/pip_deepfreeze/__main__.py 90.69% <77.77%> (-9.31%) ⬇️
src/pip_deepfreeze/compat.py 88.23% <88.23%> (ø)
src/pip_deepfreeze/env_info_json.py 88.88% <88.88%> (ø)
src/pip_deepfreeze/pip_list_json.py 88.88% <88.88%> (ø)
src/pip_deepfreeze/installed_dist.py 90.47% <90.47%> (ø)
src/pip_deepfreeze/sync.py 92.59% <90.90%> (+0.28%) ⬆️
src/pip_deepfreeze/tree.py 94.44% <94.44%> (ø)
src/pip_deepfreeze/pip.py 98.09% <96.96%> (+7.52%) ⬆️
src/pip_deepfreeze/list_installed_depends.py 100.00% <100.00%> (ø)
src/pip_deepfreeze/project_name.py 100.00% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 515067b...fc8c027. Read the comment docs.

@sbidoul sbidoul force-pushed the rm-no-use-pip-contraints-option-sbi branch from 217d3cb to f9b2ea1 Compare July 8, 2021 21:51
Because pip now supports URL in constraints.
@sbidoul sbidoul force-pushed the rm-no-use-pip-contraints-option-sbi branch from f9b2ea1 to fc8c027 Compare July 8, 2021 22:06
@sbidoul sbidoul merged commit b7798b5 into master Jul 9, 2021
@sbidoul sbidoul deleted the rm-no-use-pip-contraints-option-sbi branch July 9, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant