Memory leak when definition unshared true

[renaldyresa]

I has issue when make looping and get object with unshared set true. memory not release after function finish. Maybe because when get object, that object save in ctn.

[sarulabs]

Hello,
unshared objects are still stored in the container. This was done because they may need to be closed when the container is deleted.
You can try the branch https://github.com/sarulabs/di/tree/speed_improvements
This is a complete rewrite of the project to improve performance.
On this branch only unshared objects with a close function are stored in the container.
This should resolve your issue.
If this work I will considerer merging this branch on master. I wanted to document the new features before doing so. But it has been more than a year now and I could not find the motivation.

[renaldyresa]

Thank you, I think this can resolve my issue.

I think this is very great library, if this compare with another DI library in Go because is very easy to use and very simple.
Maybe this can give you motivation wkwk

[gaby]

@sarulabs Do you plan to merge/release the speed_improvements branch?

Any plans to continue maintaince of this library?

[sarulabs]

It's been two years already... I've really been lazy...
I'll merge the branch this weekend. Even if the documentation is not perfect.

Appart from that, I don't plan to work on new features. But I will always try to fix bugs.

[gaby]

@sarulabs Thanks! I can help you with the GitHub Actions, to cover tests, lint, etc.

[sarulabs]

The branch speed_improvements_wip that was more or less speed_improvements with improved documentation was merged into master. The version v2.5.0 was released.

[gaby]

@sarulabs Thank you, amazing work! 💪