Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disputed status of #38219 #38551

Open
saraedum opened this issue Aug 23, 2024 · 5 comments
Open

Disputed status of #38219 #38551

saraedum opened this issue Aug 23, 2024 · 5 comments

Comments

@saraedum
Copy link
Member

saraedum commented Aug 23, 2024

There has been disagreement on whether #38219 should be merged at some point.

It seems that @dimpase in particular seems to have doubts, let me quote from his messages (with the caveat that I am not sure whether he is referring to the specific PR or to the process or to the idea in generality.)

proper credits are due

I would like to know why you insist on a home-grown solution instead of something which is available.

@dimpase have these concerns been addressed? Could you clarify here what specific changes you would like to see in the PR?

@dimpase
Copy link
Member

dimpase commented Aug 24, 2024

my concerns are not addressed, and therefore I have marked #38219 as "needs work".

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 24, 2024

What is the item? Please be explicit.

@mkoeppe

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 24, 2024

Copied from #38475 (comment):

  1. the credits are not given

  2. pip has functionality to deal with hashes for binary wheels, but the PR appears to do something else, and it looks as an unnecessary complexity being added

@NathanDunfield
Copy link
Contributor

  1. pip has functionality to deal with hashes for binary wheels, but the PR appears to do something else, and it looks as an unnecessary complexity being added

Per @mkoeppe's comment on sage-devel, he initially tried to use pip's requirements.txt functionality that I believe @dimpase is referring to here, but it turned out to be insufficient because it does not support multi-platform hashes.

For what it's worth, I don't see any way to enforce hashes on binary wheels that's simpler than what's in #38219.

@mkoeppe
Copy link
Member

mkoeppe commented Aug 24, 2024

Pasechnik took to making a vague public accusation -- lacking concreteness and substantiation -- and doubling down on it in the most hostile way. This is in line of many recent public denunciations that he has been making.

It is not possible to discuss technical matters in such an abusive environment. Therefore I would strongly suggest to all to not engage in trying to interpret what Pasechnik's messages could possibly mean on a technical level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants